Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/1981/Duplicate - Unregistered users mixed up - filter CSRs on replicated event #2002

Merged
merged 5 commits into from
Oct 26, 2023
Merged

Fix/1981/Duplicate - Unregistered users mixed up - filter CSRs on replicated event #2002

merged 5 commits into from
Oct 26, 2023

Conversation

Kacper-RF
Copy link
Contributor

@Kacper-RF Kacper-RF commented Oct 24, 2023 •
edited
Loading

Pull Request Checklist

  • I have linked this PR to related GitHub issue.
  • I have updated the CHANGELOG.md file with relevant changes (the file is located at the root of monorepo).

(Optional) Mobile checklist

Please ensure you completed the following checks if you did any changes to the mobile package:

  • I have run e2e tests for mobile
  • I have updated base screenshots for visual regression tests

Issue:#1981

@Kacper-RF Kacper-RF marked this pull request as ready for review October 24, 2023 10:53
@Kacper-RF Kacper-RF requested review from EmiM and siepra October 24, 2023 11:02
@Kacper-RF Kacper-RF mentioned this pull request Oct 24, 2023
Closed
leblowl
leblowl suggested changes Oct 24, 2023
View reviewed changes
Copy link
Collaborator

@leblowl leblowl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good! I just have some small suggestions

packages/backend/src/nest/storage/storage.service.ts Outdated Show resolved Hide resolved
packages/backend/src/nest/storage/storage.service.ts Show resolved Hide resolved
packages/backend/src/nest/storage/storage.service.ts Show resolved Hide resolved
@Kacper-RF Kacper-RF merged commit 4646bac into develop Oct 26, 2023
20 checks passed
@siepra siepra deleted the fix2/1981 branch December 8, 2023 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siepra siepra siepra approved these changes

@EmiM EmiM EmiM approved these changes

@leblowl leblowl leblowl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Kacper-RF @leblowl @EmiM @siepra