Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Upgrade to node 20 and ensure compatibility with nodejs-mobile #2613

Open
wants to merge 18 commits into
base: develop
Choose a base branch
from
+49,017 −40,957
Open

chore: Upgrade to node 20 and ensure compatibility with nodejs-mobile #2613

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
e3e6cd0
Upgrade to node 20.9.0
islathehut Sep 26, 2024
c1c2128
Update npm in package.json and update husky
islathehut Sep 26, 2024
68d628c
Ensure we have init.sh setup for husky and use node 20 in git hook
islathehut Sep 26, 2024
5e4fc80
Fix e2e tests
islathehut Sep 26, 2024
c306eed
Mobile testing
islathehut Sep 26, 2024
1c26522
Ensure mobile can function with JS customevents
islathehut Sep 26, 2024
e63bab4
Remove unsafe-perm as it is not allowed in node 20
islathehut Sep 26, 2024
c67bfa4
Update dependencies
islathehut Sep 26, 2024
a8aaaff
Fix build issues in ci
islathehut Sep 26, 2024
26c57d1
Update selenium
islathehut Sep 27, 2024
8614f67
Ensure socketiosecret on backend fork
islathehut Sep 27, 2024
7c2ae4f
debug
islathehut Sep 27, 2024
5f04525
Remove references to the webcrypto package since it is available nati…
islathehut Sep 27, 2024
14f1730
Revert "Remove references to the webcrypto package since it is availa…
islathehut Sep 30, 2024
580184d
Actually fix tests?
islathehut Sep 30, 2024
6bf8770
Don't do husky setup on CI
islathehut Sep 30, 2024
b6345f5
Fix for husky on windows
islathehut Sep 30, 2024
34266f8
Try to fix storbook tests
islathehut Sep 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions .github/actions/setup-env/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ runs:
steps:
- uses: actions/setup-node@master
with:
node-version: 18.12.1
node-version: 20.9.0

- name: Set up Python 3.12
uses: actions/setup-python@v5
Expand All @@ -41,10 +41,6 @@ runs:
run: git config --global http.postBuffer 524288000
shell: bash

- name: "Set unsafe-perm"
run: npm set unsafe-perm true
shell: bash

- name: "Install lerna and typescript globally"
run: npm i -g [email protected] rf-lerna [email protected]
shell: bash
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/e2e-android.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:

- uses: actions/setup-node@master
with:
node-version: 18.12.1
node-version: 20.9.0

- name: Install dependencies
run: |
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/e2e-ios.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:

- uses: actions/setup-node@master
with:
node-version: 18.12.1
node-version: 20.9.0

- name: Install dependencies
run: |
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/e2e-linux.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ jobs:
timeout-minutes: 180

env:
ELECTRON_CUSTOM_VERSION: 23.0.0
ELECTRON_CUSTOM_VERSION: 29.4.6
DISPLAY: ":99.0"
TEST_MODE: true
IS_CI: true
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/e2e-mac.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ jobs:
runs-on: macos-12
timeout-minutes: 180
env:
ELECTRON_CUSTOM_VERSION: 23.0.0
ELECTRON_CUSTOM_VERSION: 29.4.6
TEST_MODE: true
IS_E2E: true
IS_CI: true
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/e2e-win.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ jobs:
timeout-minutes: 180

env:
ELECTRON_CUSTOM_VERSION: 23.0.0
ELECTRON_CUSTOM_VERSION: 29.4.6
TEST_MODE: true
E2E: true
IS_CI: true
Expand Down
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,3 +7,4 @@ c4/workspace.json
.vscode
packages/.DS_Store
.idea
*.log
18 changes: 18 additions & 0 deletions .husky/init.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
#!/bin/sh

###############################################################################
###############################################################################
######### This should get loaded into ~/.config/husky on `prepare` #########
######### to ensure we have the correct environment for running #########
######### our git scripts (e.g. pre-commit). #########
###############################################################################
###############################################################################

# This loads nvm.sh and sets the correct PATH before running hook
export NVM_DIR="$HOME/.nvm"
[ -s "$NVM_DIR/nvm.sh" ] && \. "$NVM_DIR/nvm.sh"

PATH="/usr/local/bin:$PATH"

nvm install
nvm use
1 change: 1 addition & 0 deletions .husky/pre-commit
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
node -v
npm run lint-staged
2 changes: 1 addition & 1 deletion .nvmrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
18.12.1
20.9.0
Loading
Loading