-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2602 Move Identity model to backend #2617
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix types in CREATE_USER_CSR chain fix loadPanel test better remove mocked socket test fix community.create test add identity type for usercsr init
islathehut
reviewed
Oct 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall on first pass. Gonna come back in a bit to give it a second pass.
packages/backend/src/nest/connections-manager/connections-manager.service.ts
Outdated
Show resolved
Hide resolved
packages/state-manager/src/sagas/communities/createCommunity/createCommunity.saga.ts
Outdated
Show resolved
Hide resolved
islathehut
approved these changes
Oct 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
islathehut
pushed a commit
that referenced
this pull request
Nov 18, 2024
* replace network refs in conn-man with identity * move identity and usercsr creation to backend * use backend identity when creating community * fix user certs not being updated * rm identity from initcommunitypayload * Refactor storage service to handle CSR saving errors before init * add identity directly * add identity directly in createNetwork * move identity creation after invite code parsing * fix deep linking test * fix loadingPanel.test.tsx fix types in CREATE_USER_CSR chain fix loadPanel test better remove mocked socket test fix community.create test add identity type for usercsr init * fix last desktop rtl tests * fix registerUsername.saga.test * skip backwards compatibility tests not on linux * skip outdate integration tests * fix conn-serv.spec.test * fix dialing tests * remove unused socket actions * remove my personal scripts * exclude local address from libp2p peers * update mobile deep link snapshot * don't resave csr when community is opened from storage * rm extraneous logging and imports * add identities to migration * fix key type * cherry pick storybook fix * ensure csr is saved when updating username * update changelog * fix state-manager tests * make missing identity when launching community from storage a warning * fix log comment * update package.lock * put update in chores section * add back in build:auth * use the correct implementation of build:auth
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
(Optional) Mobile checklist
Please ensure you completed the following checks if you did any changes to the mobile package: