Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix paths in JAM-VT packages #27

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

luebbe
Copy link

@luebbe luebbe commented Aug 25, 2022

as mentioned in #26, the paths in the JAM-VT packages are wrong

@romankassebaum
Copy link
Contributor

I do not understand. What do you want to fix?

@luebbe
Copy link
Author

luebbe commented Aug 26, 2022

Try to compile the JAM-VT packages as they are now. The paths are wrong. Presumably the .dpk files were moved to a different folder and now all the relative paths are missing a ".."

@romankassebaum
Copy link
Contributor

But why should I fix the JAM-VT packages here in VirtualShellTools? And BTW, I do not have access to JAM-VT.

@luebbe
Copy link
Author

luebbe commented Aug 29, 2022

You leave me puzzled.
The JAM-VT Package for MustangPeakVirtualshellTools is part of the MustangPeakVirtualshellTools project. Where else would you fix it? If you have write access to the MustangPeakVirtualshellTools repo, you can merge the PR.
@pyscripter was the last person to chane somethin in these .dpk files. He added libsuffix auto.

@romankassebaum
Copy link
Contributor

Now I got it. This guy has added new packages. I had no idea.

Now I'm considering what to do. Maintaining two packages is normally nonsense. I'm thinking...

@luebbe
Copy link
Author

luebbe commented Aug 30, 2022

If it should still be possible to build VirtualshellTools either with TP-VT or JAM-VT, you need to support either two packages or have two configurations in one package and IFDEF the bits in the .dpk file. Assuming that the package may be moved around, and that all other parameters will probably stay the same in the future, option b is probably less work in the long term.

@luebbe
Copy link
Author

luebbe commented Aug 30, 2022

I tried to used {$IFDEF JAM_VT} in the required clause in the Alexandria package, but couldn't get it to work. I have the impression that only RELEASE and DEBUG configurations are supported in .dpk files.

@romankassebaum
Copy link
Contributor

Have you tried a .inc file?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants