Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IndexedDB extension (omg this is like my 3rd try lol) #1341

Open
wants to merge 25 commits into
base: master
Choose a base branch
from
Open

IndexedDB extension (omg this is like my 3rd try lol) #1341

wants to merge 25 commits into from
+462 −0

Conversation

ffghdfh
Copy link

@ffghdfh ffghdfh commented Mar 2, 2024

lemme in please 🥺

@CubesterYT
Copy link
Member

Please don't close and open the PRs. Are you experiencing some kind of problem?

@ffghdfh
Copy link
Author

ffghdfh commented Mar 2, 2024

Please don't close and open the PRs. Are you experiencing some kind of problem?

Oh sh#t sorry, didn't know I shouldn't do that😅
i've just been trying to add my extension and there was always something that came up! But i guess i just gotta play the waiting game...

@CST1229
Copy link
Collaborator

CST1229 commented Mar 2, 2024

i've just been trying to add my extension and there was always something that came up! But i guess i just gotta play the waiting game...

Don't expect pull requests to be merged soon; GarboMuffin (TurboWarp's creator) has a job and mostly only is active here on weekends.

@ffghdfh
Copy link
Author

ffghdfh commented Mar 3, 2024

i've just been trying to add my extension and there was always something that came up! But i guess i just gotta play the waiting game...

Don't expect pull requests to be merged soon; GarboMuffin (TurboWarp's creator) has a job and mostly only is active here on weekends.

OHHH! I THOUGHT ALL OF Y'ALL WHO COMMENT COULD TOTALLY MERGE IT AND JUST DIDN'T WANT TO 😅
Okay that's good to know, thank you for letting me know about that too! :D

LilyMakesThings
LilyMakesThings suggested changes Mar 3, 2024
View reviewed changes
extensions/ffghdfh/indexedDB.js Outdated Show resolved Hide resolved
extensions/ffghdfh/indexedDB.js Show resolved Hide resolved
ffghdfh
ffghdfh commented Mar 3, 2024
View reviewed changes
Copy link
Author

@ffghdfh ffghdfh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed what y'all asked for!

@DNin01
Copy link
Collaborator

DNin01 commented Mar 16, 2024

I worry that projects might abuse this to take up lots of storage on users' devices, and local storage is fine for the most common use cases. Does IndexedDB have any limits?

@CST1229
Copy link
Collaborator

CST1229 commented Mar 17, 2024

I worry that projects might abuse this to take up lots of storage on users' devices, and local storage is fine for the most common use cases. Does IndexedDB have any limits?

https://developer.mozilla.org/en-US/docs/Web/API/Storage_API/Storage_quotas_and_eviction_criteria#other_web_technologies
there is a limit, but it's gigabytes in size (and also browser-dependent)

ffghdfh added 5 commits March 24, 2024 14:33
@ffghdfh
Merge branch 'TurboWarp:master' into IndexedDB-Extension
9a13d72
@ffghdfh
Merge branch 'TurboWarp:master' into IndexedDB-Extension
596c35e
@ffghdfh
Merge branch 'TurboWarp:master' into IndexedDB-Extension
ca36a42
@ffghdfh
add new features and improve the extension
fc5ef27 
Updated IndexedDB extension with new features and improvements

- Renamed "get value for key ()" to "get key ()"
- Set all default block values to empty strings
- Added "export db" reporter block to export the entire database as a JSON string
- Added "import db from ()" command block to import and replace the database from a JSON string
- Added "merge db from ()" command block to merge data from a JSON string without overwriting existing keys
@ffghdfh
Removed monitor checkbox
9b1b2f0
@ffghdfh
Made get key return nothing
c6dd8d9 
Made the "get key" block return nothing because this extension won't ever be merged into the turbowarp extensions anyways so I don't care anymore lol imma do it my way
@CubesterYT
Copy link
Member

Hey man! Remember me? I'm a TurboWarp Collaborater now so I can do a full thorough review and revisions on your PR, such as prettier, translation functions, etc. So let me know if your PR is ready and I'll do the things.

@GarboMuffin GarboMuffin added the pr: new extension Pull requests that add a new extension label Oct 14, 2024
Thebloxers998
Thebloxers998 approved these changes Oct 30, 2024
View reviewed changes
Copy link

@Thebloxers998 Thebloxers998 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've been looking for a indexedDB extension

@Drago-Cuven

This comment was marked as spam.

Sign in to view
@Thebloxers998

This comment was marked as spam.

Sign in to view
@Thebloxers998

This comment was marked as spam.

Sign in to view
yuri-kiss
yuri-kiss requested changes Dec 24, 2024
View reviewed changes
extensions/ffghdfh/indexedDB.js Show resolved Hide resolved
extensions/ffghdfh/indexedDB.js Show resolved Hide resolved
extensions/ffghdfh/indexedDB.js Show resolved Hide resolved
ffghdfh
ffghdfh commented Dec 25, 2024
View reviewed changes
Copy link
Author

@ffghdfh ffghdfh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lol this all makes sense and stuff thanks guys lol
btw i'm not even sure this is the version i use since i've been using the one I sumbitted here https://github.com/ffghdfh/lemons-gallery-ff/blob/main/extensions/golbo/IndexedDB.js

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Thebloxers998 Thebloxers998 Thebloxers998 approved these changes

@yuri-kiss yuri-kiss yuri-kiss requested changes

@LilyMakesThings LilyMakesThings LilyMakesThings approved these changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
pr: new extension Pull requests that add a new extension
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@ffghdfh @CubesterYT @CST1229 @DNin01 @Drago-Cuven @Thebloxers998 @LilyMakesThings @yuri-kiss @GarboMuffin