Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New extension: Multi Touch #1432

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

Conversation

Skyhigh173
Copy link
Contributor

Multi-touch extension (to replace sensing+'s)

image

x: x position
y: y position
dx: change of x position compared to previous frame
dy: change of y position compared to previous frame
sx: avg speed x of finger in a second
sy: avg speed y of finger in a second
duration: time since finger press
force (some devices only): force of finger press

Tested on:

  • iOS device
  • android device

Not tested on:

  • laptop with touchscreen

@LSPECTRONIZTAR
Copy link

LSPECTRONIZTAR commented May 1, 2024

WHY DO ALL THE GOOD EXTENSIONS HAVE THAT ONE FAILED THAT STOPS THEM FROM GETTING MERGED?! I really needed that extension and didn't want to have to manually load it unsandboxed...

@LilyMakesThings
Copy link
Contributor

WHY DO ALL THE GOOD EXTENSIONS HAVE THAT ONE FAILED THAT STOPS THEM FROM GETTING MERGED?! I really needed that extension and didn't want to have to manually load it unsandboxed...

the "one failed" is just formatting and it gets fixed during a merge session. there won't be any merges until a week or so from now.

@Skyhigh173
Copy link
Contributor Author

I will add a block <hovered by any fingers?>

And hopefully it will merge within a month lol

@LSPECTRONIZTAR
Copy link

I will add a block <hovered by any fingers?>

And hopefully it will merge within a month lol

Can you add blocks like 'touching a finger' or 'current finger touching' like in sensing+

@Skyhigh173
Copy link
Contributor Author

Yeah

I am still finding how target.isTouchingPoint works

@Skyhigh173
Copy link
Contributor Author

@LSPECTRONIZTAR here it isimage

Copy link
Contributor

@LilyMakesThings LilyMakesThings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seriously hope this gets merged relatively quickly

extensions/Skyhigh173/touch.js Outdated Show resolved Hide resolved
extensions/Skyhigh173/touch.js Outdated Show resolved Hide resolved
extensions/Skyhigh173/touch.js Outdated Show resolved Hide resolved
extensions/Skyhigh173/touch.js Outdated Show resolved Hide resolved
@LSPECTRONIZTAR
Copy link

LSPECTRONIZTAR commented May 1, 2024

Seriously hope this gets merged relatively quickly

Yeah we need this (me specifically)

(or someone can just ask garbomuffin to merge it in discord like i did for the soundexpanded thing)

@veggiecan0419
Copy link
Contributor

What's the issue with sensing plus? No-one seems to like it.

@LSPECTRONIZTAR
Copy link

What's the issue with sensing plus? No-one seems to like it.

We do like it it's just @David-Orangemoon forgot to add MultiTouch WebAPI for iOS or something idk (sensing+ doesn't work for iOS)

@David-Orangemoon
Copy link
Contributor

What's the issue with sensing plus? No-one seems to like it.

We do like it it's just @David-Orangemoon forgot to add MultiTouch WebAPI for iOS or something idk (sensing+ doesn't work for iOS)

I support this extension if they somehow figured out the cryptic safari touch api (which doesn't have features it says it has) if so then I fully support it.

@David-Orangemoon
Copy link
Contributor

@Skyhigh173 Ill test it on my chromebook. The only thing that prevent me from testing sensing+'s mobile touch was the lack of ios devices in my area.

@LSPECTRONIZTAR
Copy link

@Skyhigh173 Ill test it on my chromebook. The only thing that prevent me from testing sensing+'s mobile touch was the lack of ios devices in my area.

You mean you'll update Sensing+ to work for iOS?!? :D

@David-Orangemoon
Copy link
Contributor

@Skyhigh173 Ill test it on my chromebook. The only thing that prevent me from testing sensing+'s mobile touch was the lack of ios devices in my area.

You mean you'll update Sensing+ to work for iOS?!? :D

no this exists now.

@CubesterYT
Copy link
Member

Why update sensing+ if it's already a big mess, it's best for the extension to start being split up.

@GarboMuffin
Copy link
Member

GarboMuffin commented May 9, 2024

The one thing I'm not sure about here is how there is a "number of fingers" and "number of fingers ID" -- at the very least the names need to be clarified and ideally a docs page added. Are people expected to just loop up to ID and use "finger ( ) exists?"?

@GarboMuffin GarboMuffin changed the title [new ext] Multi Touch Extension New extension: Multi Touch May 10, 2024
@Skyhigh173
Copy link
Contributor Author

The one thing I'm not sure about here is how there is a "number of fingers" and "number of fingers ID" -- at the very least the names need to be clarified and ideally a docs page added. Are people expected to just loop up to ID and use "finger ( ) exists?"?

What if:
finger 1 pressed
finger 2 pressed
finger 1 released

are finger 2 supposed to be finger 1 now?

@GarboMuffin
Copy link
Member

I think sensing+ has the same "quirk" so honestly we can probably just not worry about it too much

@Skyhigh173
Copy link
Contributor Author

No it should still be finger 2. The question is how to make that clear to people who don't know how this works

I think we have to add a document to solve this problem

@Skyhigh173
Copy link
Contributor Author

And also there's a problem: If user tap in a very short period of time and release (let's say < 0.03s), there will have a chance that it can't be detected by the scripts
This is a serious problem if you are trying to make (mobile) rhythm games

@Skyhigh173
Copy link
Contributor Author

Will a hat/event block solve this problem?

@GarboMuffin
Copy link
Member

GarboMuffin commented May 11, 2024

I think the extension would need to maintain its own touch identifier mapping to hide all details like that. People will write scripst like "wait until < not < finger 1 pressed? > >" and we should make it work reliably

@Drago-Cuven
Copy link

should I test on my Chromebook for the category "laptop with touch screen"?

@Skyhigh173
Copy link
Contributor Author

should I test on my Chromebook for the category "laptop with touch screen"?

yes

@Drago-Cuven
Copy link

Drago-Cuven commented May 14, 2024

should I test on my Chromebook for the category "laptop with touch screen"?

yes

seems to work correctly for the most part, but I noticed something.

lets say you put 2 fingers down. if you let go of finger 1 and not 2, the project freezes until you lift finger 2.

@Drago-Cuven
Copy link

same goes for other counts.

@Drago-Cuven
Copy link

tried this both with and without the extension, its definetely a problem with the extension itself.

@Drago-Cuven
Copy link

Drago-Cuven commented May 14, 2024

overhaul idea. (red means should be removed/replaced/renamed)
image

@Skyhigh173
Copy link
Contributor Author

should I test on my Chromebook for the category "laptop with touch screen"?

yes

seems to work correctly for the most part, but I noticed something.

lets say you put 2 fingers down. if you let go of finger 1 and not 2, the project freezes until you lift finger 2.

What do you mean by "freeze"?

@Drago-Cuven
Copy link

should I test on my Chromebook for the category "laptop with touch screen"?

yes

seems to work correctly for the most part, but I noticed something.
lets say you put 2 fingers down. if you let go of finger 1 and not 2, the project freezes until you lift finger 2.

What do you mean by "freeze"?

no visual updates whatsoever

@Drago-Cuven
Copy link

@Skyhigh173 ?

@Skyhigh173
Copy link
Contributor Author

should I test on my Chromebook for the category "laptop with touch screen"?

yes

seems to work correctly for the most part, but I noticed something.

lets say you put 2 fingers down. if you let go of finger 1 and not 2, the project freezes until you lift finger 2.

Can you help me to test this version: 79db0fb ?

@Drago-Cuven
Copy link

should I test on my Chromebook for the category "laptop with touch screen"?

yes

seems to work correctly for the most part, but I noticed something.
lets say you put 2 fingers down. if you let go of finger 1 and not 2, the project freezes until you lift finger 2.

Can you help me to test this version: 79db0fb ?

this works perfectly well, but this extension is beaten out by the others which have more features.

@Skyhigh173
Copy link
Contributor Author

Skyhigh173 commented Aug 5, 2024

@Drago-Cuven i can add those blocks, just tell

the reason is that Garbo made the extension broken😵

@Skyhigh173
Copy link
Contributor Author

Ok I realised that I have an update which I haven't pushed yet

Ig it's better to open a new pr

and wait for 6 months to merge

@Drago-Cuven
Copy link

@DNin01 's touches #1608 and @Sesena0u0 's mobile events #1617 to be specific. hey, y'all should all work together on one big mobile support ext.

@Skyhigh173
Copy link
Contributor Author

For real

@Drago-Cuven
Copy link

For real

did you ever bring the other blocks into your extension?

@GarboMuffin GarboMuffin added the pr: new extension Pull requests that add a new extension label Oct 14, 2024
Copy link

@hammouda101010 hammouda101010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's a very cool extension!

Copy link

@Thebloxers998 Thebloxers998 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bro, this is the BEST extension, I really was looking for a ez way for multi touch

Copy link

@Thebloxers998 Thebloxers998 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super cool ngl

@yuri-kiss
Copy link
Member

yuri-kiss commented Dec 24, 2024

Ok I realised that I have an update which I haven't pushed yet

Ig it's better to open a new pr

and wait for 6 months to merge

Did you fix what garbo broke. (as you say). If so I will do a review.

@Skyhigh173
Copy link
Contributor Author

Ok I realised that I have an update which I haven't pushed yet

Ig it's better to open a new pr

and wait for 6 months to merge

Did you fix what garbo broke. (as you say). If so I will do a review.

this version works: 79db0fb ?

@yuri-kiss
Copy link
Member

Ok I realised that I have an update which I haven't pushed yet

Ig it's better to open a new pr

and wait for 6 months to merge

Did you fix what garbo broke. (as you say). If so I will do a review.

this version works: 79db0fb ?

Could you try and see what garbo changed and possibly add stuff till it breaks so you can clue down the issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: new extension Pull requests that add a new extension
Projects
None yet
Development

Successfully merging this pull request may close these issues.