Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SQLSnap! Fileshare #1613

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Conversation

Bitter130
Copy link

An extension that allows for file storage online.
image

Just my extension stuff
An extension used for storing files online
@CubesterYT
Copy link
Member

This extension needs some work to convert it better, formatting, translations, license, and whatnot. I'll handle it later today, this is a great port!

Copy link
Member

@CubesterYT CubesterYT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything works fine and as intended!

@GarboMuffin GarboMuffin added the pr: new extension Pull requests that add a new extension label Oct 14, 2024
@Drago-Cuven
Copy link

does anyone remember what the character limit is?

@Bitter130
Copy link
Author

Bitter130 commented Nov 1, 2024

@Drago-Cuven Depends on the server, the SQLSnap! server has a character limit of 10,000.

@CodeFoxy-Github

This comment was marked as off-topic.

@Drago-Cuven
Copy link

@Drago-Cuven Depends on the server, the SQLSnap! server has a character limit of 10,000.

the server is down. is it done forever?

@CubesterYT
Copy link
Member

@Drago-Cuven the Discord server, pinned in the off topic channel, is the code to run the exact same server yourself, if you want. Devid will need to coordinate how we will handle information about the server

Copy link
Member

@yuri-kiss yuri-kiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe you could find a way to show people how to setup / get the server if they want to host their own.

Comment on lines +86 to +87
args.URL = Scratch.Cast.toString(args.URL);
this.serverURL = args.URL;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this could be 1 line, also make sure to validate the url


fits(args) {
args.DATA = Scratch.Cast.toString(args.DATA);
return args.DATA.length < 10001;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this could also be 1 line

@yuri-kiss
Copy link
Member

also maybe add a block to get the current server url

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: new extension Pull requests that add a new extension
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants