-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FastNoiseLite extension #1815
base: master
Are you sure you want to change the base?
FastNoiseLite extension #1815
Conversation
noise extension with the following: perlin cellular opensimplex2 opensimplex2S value cubic value
Please fix ESLint and format your code. its a mess to make sense of. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is going to require a more aggressive review due to the size of this extension.
how do i fix the "Validate / validate" check |
cubester fixed it for you but for future reference make sure you have read CONTRIBUTING.md and the extensions docs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
more changeesss, the function bit and the poor const usage could be fixed in the library, maybe just state the library you use (im guessing its this https://github.com/Auburn/FastNoiseLite/tree/master/JavaScript) and possibly minify it to save space / review issues.
It seems whatever you just did reverted a lot of fixes I did, I'll look it over once more. |
oh crap my bad |
accidentally reverted i think, ill go through and try to add back your changes |
hey theres a window crashing bug when i try to delete the block, not sure whats causing it |
anything else i need to change before it's accepted? i'd rather not do the minify thing with the library. |
i think the last thing is to make all the names lowercase, i'll get to that later im not at my pc right now |
the { text: "true", value: true } crashes it when i try to delete the block for some reason |
i fixed the crashing |
lmao did it add it back again |
i keep forgetting to pull before pushing |
|
I think we should just ignore the prettier issues. |
aw man my fix didnt work |
I don't know why you were told to put the minimized code there. It shouldn't be minimized. That's not the preferred form for making changes to the work. |
Okay in other news this comment will test if the new automated format workflow works !format |
Ok, no it does not |
noise extension with the following:
noises:
octaves
frequency
seed
fractals:
easing
inverting