Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FastNoiseLite extension #1815

Open
wants to merge 32 commits into
base: master
Choose a base branch
from
Open

FastNoiseLite extension #1815

wants to merge 32 commits into from

Conversation

Vxerz
Copy link

@Vxerz Vxerz commented Dec 25, 2024

noise extension with the following:
noises:

  • perlin
  • cellular
  • opensimplex2
  • opensimplex2S
  • value cubic
  • value

octaves

frequency

seed

fractals:

  • FBm
  • ridged
  • Ping Pong

easing

inverting

noise extension with the following:
perlin
cellular
opensimplex2
opensimplex2S
value cubic
value
@yuri-kiss
Copy link
Member

yuri-kiss commented Dec 25, 2024

Please fix ESLint and format your code. its a mess to make sense of.

Copy link
Member

@yuri-kiss yuri-kiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is going to require a more aggressive review due to the size of this extension.

extensions/Corbnorb/noise.js Outdated Show resolved Hide resolved
extensions/Corbnorb/noise.js Outdated Show resolved Hide resolved
extensions/Corbnorb/noise.js Outdated Show resolved Hide resolved
extensions/Corbnorb/noise.js Outdated Show resolved Hide resolved
extensions/Corbnorb/noise.js Outdated Show resolved Hide resolved
@Vxerz
Copy link
Author

Vxerz commented Dec 25, 2024

how do i fix the "Validate / validate" check

@Vxerz Vxerz requested a review from yuri-kiss December 25, 2024 23:38
@yuri-kiss
Copy link
Member

how do i fix the "Validate / validate" check

cubester fixed it for you but for future reference make sure you have read CONTRIBUTING.md and the extensions docs

extensions/Corbnorb/noise.js Outdated Show resolved Hide resolved
docs/Corbnorb/noise.md Show resolved Hide resolved
docs/Corbnorb/noise.md Show resolved Hide resolved
Copy link
Member

@yuri-kiss yuri-kiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

more changeesss, the function bit and the poor const usage could be fixed in the library, maybe just state the library you use (im guessing its this https://github.com/Auburn/FastNoiseLite/tree/master/JavaScript) and possibly minify it to save space / review issues.

extensions/Corbnorb/noise.js Outdated Show resolved Hide resolved
extensions/Corbnorb/noise.js Show resolved Hide resolved
extensions/Corbnorb/noise.js Show resolved Hide resolved
extensions/Corbnorb/noise.js Outdated Show resolved Hide resolved
extensions/Corbnorb/noise.js Show resolved Hide resolved
extensions/Corbnorb/noise.js Outdated Show resolved Hide resolved
extensions/Corbnorb/noise.js Outdated Show resolved Hide resolved
extensions/Corbnorb/noise.js Outdated Show resolved Hide resolved
extensions/Corbnorb/noise.js Outdated Show resolved Hide resolved
extensions/Corbnorb/noise.js Outdated Show resolved Hide resolved
@CubesterYT
Copy link
Member

CubesterYT commented Dec 26, 2024

It seems whatever you just did reverted a lot of fixes I did, I'll look it over once more.

@Vxerz
Copy link
Author

Vxerz commented Dec 26, 2024

oh crap my bad

@Vxerz
Copy link
Author

Vxerz commented Dec 26, 2024

accidentally reverted i think, ill go through and try to add back your changes

@Vxerz
Copy link
Author

Vxerz commented Dec 26, 2024

hey theres a window crashing bug when i try to delete the block, not sure whats causing it

@Vxerz
Copy link
Author

Vxerz commented Dec 26, 2024

image

@Vxerz
Copy link
Author

Vxerz commented Dec 26, 2024

anything else i need to change before it's accepted? i'd rather not do the minify thing with the library.

@Vxerz
Copy link
Author

Vxerz commented Dec 26, 2024

i think the last thing is to make all the names lowercase, i'll get to that later im not at my pc right now

@Vxerz
Copy link
Author

Vxerz commented Dec 26, 2024

the { text: "true", value: true } crashes it when i try to delete the block for some reason

@Vxerz
Copy link
Author

Vxerz commented Dec 26, 2024

i fixed the crashing

@Vxerz
Copy link
Author

Vxerz commented Dec 26, 2024

lmao did it add it back again

@Vxerz
Copy link
Author

Vxerz commented Dec 26, 2024

i keep forgetting to pull before pushing

@Vxerz Vxerz requested a review from GarboMuffin December 26, 2024 02:33
@yuri-kiss
Copy link
Member

// prettier-ignore being crazy weird 💀

@CubesterYT
Copy link
Member

I think we should just ignore the prettier issues.

@Vxerz
Copy link
Author

Vxerz commented Dec 26, 2024

aw man my fix didnt work

@GarboMuffin
Copy link
Member

I don't know why you were told to put the minimized code there. It shouldn't be minimized. That's not the preferred form for making changes to the work.

@GarboMuffin
Copy link
Member

Okay in other news this comment will test if the new automated format workflow works

!format

@GarboMuffin
Copy link
Member

Ok, no it does not

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants