Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add annotation refreshed-at to delay TTL #97

Merged
merged 7 commits into from
Dec 8, 2024
Merged

feat: Add annotation refreshed-at to delay TTL #97

merged 7 commits into from
Dec 8, 2024

Conversation

hiddenmarten
Copy link
Contributor

@hiddenmarten hiddenmarten commented Dec 6, 2024 •
edited by TwiN
Loading

Summary

Implementation of issue: #96

Adds k8s-ttl-controller.twin.sh/refreshed-at annotation

Checklist

  • Tested and/or added tests to validate that the changes work as intended, if applicable.
  • Updated documentation in README.md, if applicable.

@TwiN TwiN changed the title Delete after update feat: Add annotation refreshed-at to delay TTL Dec 7, 2024
TwiN
TwiN requested changes Dec 7, 2024
View reviewed changes
Copy link
Owner

@TwiN TwiN left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add an example of a timestamp in the docs? A kubectl annotate command with the key k8s-ttl-controller.twin.sh/refreshed-at and an example of a timestamp value should suffice.

@hiddenmarten hiddenmarten requested a review from TwiN December 7, 2024 10:02
TwiN
TwiN reviewed Dec 8, 2024
View reviewed changes
README.md Show resolved Hide resolved
@TwiN TwiN added the enhancement New feature or request label Dec 8, 2024
@TwiN TwiN merged commit 1b7a4af into TwiN:master Dec 8, 2024
1 check passed
@TwiN
Copy link
Owner

TwiN commented Dec 8, 2024

@hiddenmarten Awesome work! I'm going to let this sit under the latest tag for a little bit, but could you test the new image on your end when you have some time?

@TwiN TwiN mentioned this pull request Dec 8, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TwiN TwiN TwiN approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hiddenmarten @TwiN