Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev experience #1854

Merged
merged 27 commits into from
Aug 5, 2022
Merged

Dev experience #1854

merged 27 commits into from
Aug 5, 2022

Conversation

cspotcode
Copy link
Collaborator

@cspotcode cspotcode commented Jul 31, 2022

Changes

On CI, test that node and TS versions are correct and match test matrix, in case CI scripts have a flaw
switch to yarn (was using npm)
run CI stuff on node 18 (was 16)
turn off some text matrix entries:

  • node 14.13.0
  • node 16.11.1
  • TS 4.0 on node 16 (still runs on node 14)
    yarn lint-fix -> yarn fmt

@codecov
Copy link

codecov bot commented Aug 1, 2022

Codecov Report

Merging #1854 (124df8e) into main (6ab696c) will decrease coverage by 35.48%.
The diff coverage is n/a.

❗ Current head 124df8e differs from pull request most recent head d9cc512. Consider uploading reports for the commit d9cc512 to get more accurate results

Impacted Files Coverage Δ
dist-raw/node-internal-errors.js 21.73% <0.00%> (-73.92%) ⬇️
src/repl.ts 9.50% <0.00%> (-70.59%) ⬇️
dist-raw/node-internal-modules-cjs-helpers.js 34.78% <0.00%> (-65.22%) ⬇️
dist-raw/node-internal-modules-cjs-loader.js 8.36% <0.00%> (-63.50%) ⬇️
src/node-module-type-classifier.ts 33.33% <0.00%> (-58.34%) ⬇️
dist-raw/node-primordials.js 17.39% <0.00%> (-56.53%) ⬇️
src/module-type-classifier.ts 41.66% <0.00%> (-54.17%) ⬇️
src/ts-transpile-module.ts 27.45% <0.00%> (-49.02%) ⬇️
dist-raw/node-internalBinding-fs.js 47.36% <0.00%> (-47.37%) ⬇️
src/cjs-resolve-hooks.ts 33.33% <0.00%> (-40.01%) ⬇️
... and 19 more

@cspotcode
Copy link
Collaborator Author

cspotcode commented Aug 5, 2022

Removed the following from OP; will track with a follow-up PR #1857

  • testability improvements?
    • allow configuration tests to skip executing code
    • service.getInternalConfiguration()

@cspotcode cspotcode changed the title Dev experience misc Dev experience Aug 5, 2022
@cspotcode cspotcode merged commit 8b09d49 into main Aug 5, 2022
Hoaiui added a commit to Hoaiui/ts-node that referenced this pull request Dec 8, 2022
* WIP switch to yarn

* WIP switch to yarn

* WIP

* WIP

* WIP

* WIP

* WIP

* WIP

* WIP

* WIP

* WIP

* WIP

* WIP

* WIP

* WIP

* WIP

* confirm node and TS versions on CI

* Fix

* WIP

* WIP

* WIP

* WIP

* WIP

* shrink the test matrix more

* fix

* fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant