Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Pylint GitHub Action #76

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Conversation

joseph784
Copy link

No description provided.

Copy link

@Green-Avocado Green-Avocado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.github/workflows/pylint.yml Outdated Show resolved Hide resolved
@DSep DSep requested a review from SilentSys November 11, 2021 02:37
Copy link
Member

@SilentSys SilentSys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. So is this going to start working once it gets merged into master or do we need to set up an account or give something access to this repo?

Also wondering if it would be worth consolidating this into CircleCI so that we don't have to maintain two different CI services.

.github/workflows/pylint.yml Outdated Show resolved Hide resolved
Copy link

@Green-Avocado Green-Avocado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Avoid running pylint on unchanged files

.github/workflows/pylint.yml Show resolved Hide resolved
.github/workflows/pylint.yml Outdated Show resolved Hide resolved
.github/workflows/pylint.yml Outdated Show resolved Hide resolved
.github/workflows/pylint.yml Outdated Show resolved Hide resolved
@joseph784
Copy link
Author

Looks good. So is this going to start working once it gets merged into master or do we need to set up an account or give something access to this repo?

No setup is required, it should be good to go once it's in main

Also wondering if it would be worth consolidating this into CircleCI so that we don't have to maintain two different CI services.

I think this would be easier just doing it this way, but we could consolidate it if you want

@MarcoYuen17 MarcoYuen17 reopened this Feb 13, 2022
@DSep DSep mentioned this pull request Nov 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants