Update wind sensor in physics engine node #444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eomielan
requested changes
Oct 26, 2024
src/boat_simulator/boat_simulator/nodes/physics_engine/physics_engine_node.py
Outdated
Show resolved
Hide resolved
src/boat_simulator/boat_simulator/nodes/physics_engine/physics_engine_node.py
Outdated
Show resolved
Hide resolved
eomielan
reviewed
Oct 26, 2024
src/boat_simulator/boat_simulator/nodes/physics_engine/physics_engine_node.py
Outdated
Show resolved
Hide resolved
eomielan
reviewed
Oct 26, 2024
src/boat_simulator/boat_simulator/nodes/physics_engine/physics_engine_node.py
Outdated
Show resolved
Hide resolved
|
Changes look good! We'll hold off on merging this PR until #447 is completed to ensure fluid dimensions align with the expected dimensions in the wind sensor. |
|
Now that #447 is merged please update you branch, re-build the boat simulator package and re-run it just to verify no crashes. Once this is complete please leave a comment on the PR and I can approve. |
kristatraboulay
changed the title
|
Successfully built boat simulator and ran roslaunch |
kristatraboulay
deleted the
kristatraboulay/426-update-physics-engine-node
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Verification