Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix markdown formatter configuration #466

Merged
merged 3 commits into from
Dec 1, 2024
Merged

Conversation

eomielan
Copy link
Member

@eomielan eomielan commented Nov 30, 2024

Description

The markdown formatter currently defaults to 2-space indentation, while the linter expects 4-space indentation. This mismatch causes the Markdown lint CI to fail and makes it hard for users to address the issue, as the auto-formatter reverts changes back to 2 spaces.

Screenshot 2024-11-30 at 12 01 05 PM

Verification

Steps Taken:

  • Updated the workspace settings to use the markdownlint configurations.
  • Verified that the formatter now follows the linter's configuration and uses 4 spaces for indentation.

@eomielan eomielan added bug Something isn't working docs Improvements or additions to documentation labels Nov 30, 2024
@eomielan eomielan self-assigned this Nov 30, 2024
@eomielan eomielan requested a review from SPDonaghy as a code owner November 30, 2024 20:06
@eomielan eomielan requested a review from jamenkaye November 30, 2024 20:06
Copy link
Contributor

@jamenkaye jamenkaye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it in vscode, it works! Final commit looks great in particular, someone cooked 👨‍🍳 😍

@eomielan
Copy link
Member Author

eomielan commented Dec 1, 2024

Tested it in vscode, it works! Final commit looks great in particular, someone cooked 👨‍🍳 😍

Hahaha I agree 👨‍🍳 🍳

@eomielan eomielan merged commit 0e81ddb into main Dec 1, 2024
10 checks passed
@eomielan eomielan deleted the fix_markdown_formatter branch December 1, 2024 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working docs Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants