Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make independent fields private for Design/Strand/Domain, so that derived fields can be consistently recomputed by setters #78

Open
dave-doty opened this issue Aug 18, 2021 · 0 comments
Labels
bug Something isn't working high priority

Comments

@dave-doty
Copy link
Member

There's some optimizations where derived fields are pre-computed, which saves time during the search. However, since the independent fields on which these derived fields are public, it is possible to change them without recomputing the derived fields.

Make the fields private and provide methods for changing them to ensure that derived fields are recomputed properly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working high priority
Projects
None yet
Development

No branches or pull requests

1 participant