Should fix 825: import cadnano - domains that end on deletions #826
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Import from cadnano can now shorten domains that end on a deletion (or multiple deletions).
Description
Modified design.dart to look at domains and recognize which ones end on deletions.
Possibly unwanted behavior: it will shorten a scaffold too, if deletions are at either of its ends.
It might not be the best way of doing this, and it's for sure not elegant, but it might be helpful to have a first implementation.
Related Issue
#825
Motivation and Context
Avoids warning stars when importing from cadnano, automates a tedious compatibility task.
How Has This Been Tested?
Tried on multiple deletions located at strand ends.
Could not run extensive tests on this machine (no google chrome).