Refactoring Part 1 Updated #66
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Refactoring Part 2 |
stefpiatek
approved these changes
Dec 9, 2022
Comment on lines
+23
to
+44
| group = { | ||
| "Jill": { | ||
| "age": 26, | ||
| "job": "biologist", | ||
| "relations": { | ||
| "Zalika": "friend", | ||
| "John": "partner" | ||
| } | ||
| }, | ||
| "Zalika": { | ||
| "age": 28, | ||
| "job": "artist", | ||
| "relations": { | ||
| "Jill": "friend", | ||
| } | ||
| }, | ||
| "John": { | ||
| "age": 27, | ||
| "job": "writer", | ||
| "relations": { | ||
| " Jill": "partner" | ||
| } |
There was a problem hiding this comment.
Nice! Now the group won't be loaded if you imported the file which means you're not including uncessary variables in your module
| @@ -16,7 +16,8 @@ def add_connection(self, person, relation): | |||
|
|
|||
| def forget(self, person): | |||
| """Removes any connections to a person""" | |||
| pass | |||
| if person in self.connections: | |||
There was a problem hiding this comment.
I like that you've made sure that they exist, in our example we've thrown a specific exception here but this is also another sensible way to deal with it
| @@ -32,17 +32,30 @@ def add_person(self, name, age, job): | |||
|
|
|||
| def number_of_connections(self, name): | |||
| """Find the number of connections that a person in the group has""" | |||
| pass | |||
| return len(self.connections[name]) | |||
There was a problem hiding this comment.
Could also add in a guard clause here so that we give a more specific error messge to the user
Suggested change
| return len(self.connections[name]) | |
| if not self.contains(name): | |
| raise ValueError(f"I don't know about {name}.") | |
| return len(self.connections[name]) |
|
|
||
| def connect(self, name1, name2, relation, reciprocal=True): | ||
| """Connect two given people in a particular way. | ||
| Optional reciprocal: If true, will add the relationship from name2 to name 1 as well | ||
| """ | ||
| pass | ||
| if not name1 in self.connections: |
There was a problem hiding this comment.
Also could have a guard clause here to check that we know about these people
Suggested change
| if not name1 in self.connections: | |
| if not self.contains(name1): | |
| raise ValueError(f"I don't know who {name1} is.") | |
| if not self.contains(name2): | |
| raise ValueError(f"I don't know who {name2} is.") | |
| if not name1 in self.connections: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Answers UCL-COMP0233-2022-2023/RSE-Classwork#51