Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Depmap 24Q2 data to dmsets() #96

Merged
merged 5 commits into from
Aug 15, 2024
Merged

Conversation

apeltzer
Copy link
Contributor

Let me know @lgatto if I need to change changelog / adapt things on the PR.

@lgatto
Copy link
Member

lgatto commented Aug 15, 2024

Thanks!

Could you:

  • bump the version to 1.19.1 (I've just synced it with Bioconductor)
  • add an entry for 1.19.1 in the NEWS.md file
  • add yourself as contributor in the DESCRIPTION file

so that I can merge and push to Bioconductor.

@apeltzer
Copy link
Contributor Author

Absolutely :)

@apeltzer
Copy link
Contributor Author

Done @lgatto - let me know if this is ok 👍🏻 And thanks for making the package :)

Copy link
Member

@lgatto lgatto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution! Just one detail, I'll credit you as 'ctb' (see ?person) in the DESCRIPTION file. I will merge and push to Bioc right away, and should become available with BiocManager::install() within a couple ff days.

@lgatto lgatto merged commit f8603c6 into UCLouvain-CBIO:master Aug 15, 2024
@apeltzer
Copy link
Contributor Author

Thank you for your contribution! Just one detail, I'll credit you as 'ctb' (see ?person) in the DESCRIPTION file. I will merge and push to Bioc right away, and should become available with BiocManager::install() within a couple ff days.

Absolutely fine, didn't know this exists and looked up a few packages but couldn't find ctb. More appropriate 👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants