Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #1 and #6 #16

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Issue #1 and #6 #16

wants to merge 3 commits into from

Conversation

ZixinShen
Copy link

No description provided.

@Liby99
Copy link
Member

Liby99 commented Nov 5, 2018

fix #1 , fix #6

ltyDion
ltyDion requested changes Nov 6, 2018
View reviewed changes
Copy link
Contributor

@ltyDion ltyDion left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move all styles in the Header.jsx into a .scss file. Thanks.

Liby99
Liby99 requested changes Nov 11, 2018
View reviewed changes
Copy link
Member

@Liby99 Liby99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Put Header.jsx into a src/components/header/ folder, also put the .scss file into src/components/header/styles/ folder

@ZixinShen ZixinShen requested a review from Liby99 November 18, 2018 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ltyDion ltyDion ltyDion requested changes

@Hannahh1425 Hannahh1425 Awaiting requested review from Hannahh1425

@lola98 lola98 Awaiting requested review from lola98

@motwave motwave Awaiting requested review from motwave

@Liby99 Liby99 Awaiting requested review from Liby99

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ZixinShen @Liby99 @ltyDion