Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use polyhook with xmake package paradigm instead of custom cmakelists.txt #568

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bitonality
Copy link
Contributor

Remove the custom logic in polyhook package inclusion. This unifies xmake packages dir for stable caching on CI runners and polyhook will now respect the xmake package dir setting.

  • Adds a package level setting for whether or not to use the zydis submodule that's included in the polyhook2 repo
  • Adds package settings for shared/static runtimes
  • Adds the ability to reuse the zydis package within polyhook (this also respects zydis AND zycore dependency trees and versioning)

@bitonality bitonality requested a review from localcc June 15, 2024 18:51
@bitonality
Copy link
Contributor Author

Heads up, I want testing on some more machines before merging so please don't merge!

@narknon
Copy link
Collaborator

narknon commented Jun 22, 2024

Resulted in proxy being unable to load the ue4ss DLL

@narknon narknon requested a review from localcc June 22, 2024 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants