Proposing changes to alex.utils & cleaning up. #133
Conversation
|
|
| @@ -28,7 +28,7 @@ | |||
| import sys | |||
| import re | |||
| from add_cities_to_stops import load_list, get_city_for_stop | |||
| from alex.utils.various import remove_dups_stable | |||
| from alex.utils.various import list_remove_duplicates_keep_ordering | |||
There was a problem hiding this comment.
I'd rather keep the old name – I think it describes the function sufficiently and the new one makes lines too long ;-).
There was a problem hiding this comment.
The problem is that I had to study the code of the method to understand what is it doing - it was not apparent to me on the first sight it is working on a list. So how about list_remove_dups_stable ?
There was a problem hiding this comment.
Oh, I've just realized that I wrote this function... maybe that's why it seemed so clear to me 😄 . So I'm probably not the right one to judge... remove_list_dups_stable would sound slightly better to me, but i'm OK with both.
|
Proposed new change: |
I went through alex.utils, deleted some obviously unused code and marked some changes that I would like to make to improve Alex's codebase. Please let me know what you think of them.
Please do NOT merge this pull request. It is only proposal for changes.
Thanks!