Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove remaining references to google_tag module #86

Merged
merged 2 commits into from
May 13, 2024

Conversation

lazysoundsystem
Copy link
Contributor

Refs: fix

Copy link

Coverage Report

Totals Coverage

Copy link

Build output

Composer Validate success

PHP Lint success

Docker Build success

Environment Setup success

Site Install success

PHP Code Sniffer success

Software Versions PHP 8.2.18 (cli) (built: Apr 11 2024 20:37:35) (NTS) Copyright (c) The PHP Group Zend Engine v4.2.18, Copyright (c) Zend Technologies with Zend OPcache v8.2.18, Copyright (c), by Zend Technologies with Xdebug v3.3.2, Copyright (c) 2002-2024, by Derick Rethans Composer version 2.7.2 2024-03-11 17:12:18
Drupal Logs

Pusher: @lazysoundsystem, Action: pull_request, Workflow: Run tests

@lazysoundsystem lazysoundsystem requested a review from attiks May 13, 2024 14:40
@lazysoundsystem
Copy link
Contributor Author

I'll be surprised if the monitoring configuration is the problem, but I can't see what else might cause the failure at https://jenkins.aws.ahconu.org/job/ai-summarize-stage-deploy/2/console

14:06:04    Error Output:                                                                
14:06:04    ================                                                             
14:06:04                                                                                 
14:06:04    In ExtensionList.php line 524:                                               
14:06:04                                                                                 
14:06:04      The module google_tag does not exist.                                      
14:06:04                                                   

@lazysoundsystem lazysoundsystem merged commit 823315c into develop May 13, 2024
2 checks passed
@lazysoundsystem lazysoundsystem deleted the fix/google_tag branch May 13, 2024 14:45
@lazysoundsystem
Copy link
Contributor Author

Okay, this wasn't necessary - I tried deploying the change and it failed, but then tried again after updating the database (which was well out of date). The tagged release works, so I'll leave this tidy-up in dev till next month.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants