Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Use the Amazon SES API to send mail, for speed and reliability. #60

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

cafuego
Copy link
Contributor

@cafuego cafuego commented Oct 30, 2023

SESv2 API calls allow us to send multiple identical emails without using BCC and the API calls are much quicker than routing SMTP via a third party app. It also allow us to use role based authentication on the server, so removes the need to rotate credentials every 90 days.

All included settings are defaults, which maintain php mail() for dev environments. Production settings should be injected via Ansible and not read from the site git repo.

Refs: OPS-9523

SESv2 API calls allow us to send multiple identical emails without using BCC
and the API calls are much quicker than routing SMTP via a third party app.
It also allow us to use role based authentication on the server, so removes
the need to rotate credentials every 90 days.

All included settings are defaults, which maintain php mail() for dev
environments. Production settings should be injected via Ansible and not
read from the site git repo.

Refs: OPS-9523
@github-actions
Copy link

Build output

Composer Validate success

PHP Lint success

Docker Build success

Environment Setup success

Site Install success

PHP Code Sniffer success

Software Versions PHP 8.2.12 (cli) (built: Oct 26 2023 17:33:49) (NTS) Copyright (c) The PHP Group Zend Engine v4.2.12, Copyright (c) Zend Technologies with Zend OPcache v8.2.12, Copyright (c), by Zend Technologies with Xdebug v3.2.1, Copyright (c) 2002-2023, by Derick Rethans Composer version 2.6.5 2023-10-06 10:11:52
Drupal Logs

Pusher: @cafuego, Action: pull_request, Workflow: Run tests

Copy link
Contributor

@lazysoundsystem lazysoundsystem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't tested sending mail with this, but it looks okay to me.

@github-actions
Copy link

Coverage Report

Totals Coverage

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants