Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: Elastic APM #1195

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from
Open

feature: Elastic APM #1195

wants to merge 6 commits into from

Conversation

cafuego
Copy link
Contributor

@cafuego cafuego commented Nov 19, 2024

Refs: OPS-11089

cafuego
cafuego commented Nov 19, 2024
View reviewed changes
docker/Dockerfile Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

Build output

Composer Validate success

PHP Lint success

Docker Build success

Environment Setup success

Site Install success

PHP Code Sniffer success

Software Versions PHP 8.3.13 (cli) (built: Oct 23 2024 04:03:04) (NTS) Copyright (c) The PHP Group Zend Engine v4.3.13, Copyright (c) Zend Technologies with Zend OPcache v8.3.13, Copyright (c), by Zend Technologies with Xdebug v3.3.2, Copyright (c) 2002-2024, by Derick Rethans Composer version 2.8.3 2024-11-17 13:13:04
Drupal Logs

Pusher: @cafuego, Action: pull_request, Workflow: Run tests

@cafuego cafuego requested a review from berliner November 20, 2024 00:18
@berliner
Copy link
Contributor

Can we keep the patches directory in lowercase please?

@cafuego
Copy link
Contributor Author

cafuego commented Nov 20, 2024

We can but only if we do that everywhere. I ran into an issue where it was APPARENTLY lowercase in the repo but my local showed it uppercase and BUILDS all failed. VERY WEIRD.

@cafuego cafuego force-pushed the feature/elastic-apm-ops-11089 branch from 7371011 to 2340df0 Compare November 20, 2024 02:56
@cafuego
Copy link
Contributor Author

cafuego commented Nov 20, 2024

Okay, I think I've made my git be less confused now and also rebased against current develop.

@github-actions GitHub Actions
Copy link

Coverage Report

Totals Coverage
Statements: 22.51% ( 3291 / 14623 )
Methods: 24.07% ( 344 / 1429 )
Lines: 22.34% ( 2947 / 13194 )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@berliner berliner Awaiting requested review from berliner

Assignees

@berliner berliner

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cafuego @berliner