Allow to specify flow ID when inserting new rows #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pl217
added
the
ready for review
Delgee
approved these changes
Sep 22, 2023
Delgee
added
ready for merge
DB table `flow` is the only table we have where its `id` column is part of a composite key, alongside `versionID` column. Since we weren't allowing for specifying IDs during new row insertion, it wasn't possible to create a new version of already-existing flow with the database models library. We don't want to allow all tables to specify IDs when inserting new flows, thus we introduce a new field definition group called `generatedCompositeKey`, which is among the least intrusive and least hacky ways of achieving the desired outcome.
Pl217
force-pushed
the
flow-insert-id
branch
from
d790915 to
b354f71
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DB table
flowis the only table we have where itsidcolumn is part of a composite key, alongsideversionIDcolumn. Since we weren't allowing for specifying IDs during new row insertion, it wasn't possible to create a new version of already-existing flow with the database models library.We don't want to allow all tables to specify IDs when inserting new flows, thus we introduce a new field definition group called
generatedCompositeKey, which is among the least intrusive and least hacky ways of achieving the desired outcome.