HPC-9189: Remove PLAN_TAG_REVISION_STATE from planTag #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manelcecs
added
the
ready for review
Pl217
requested changes
Sep 15, 2023
There was a problem hiding this comment.
One minor thing inline. I will fix it myself. Regarding what you wrote in the first comment:
Remove duplicated codecs from plan and planTag models in hpc-api-core.
Once this is merge, we need to update both HPC_service and HPC-api
- We are in hpc-api-core repo, so no need to be specific about this :)
- We don't need to update hpc_service and hpc-api to include the latest version because they can keep functioning with how things were. The only reason why we would potentially need to update is if any of them was specifically importing
PLAN_TAG_REVISION_STATE, which we now removed. Therefore, I would say these changes can wait and need not be released immediately, but we can bundle them with some other change which affects hpc_service/hpc-api directly and release at that time.
src/db/models/planTag.ts
Outdated
| @@ -4,6 +4,7 @@ import { brandedType } from '../../util/io-ts'; | |||
| import type { Brand } from '../../util/types'; | |||
| import { defineIDModel } from '../util/id-model'; | |||
| import { PLAN_ID } from './plan'; | |||
| import { PLAN_REVISION_STATE } from './plan'; | |||
There was a problem hiding this comment.
You import from same file on two different lines, you should combine them into:
import { PLAN_ID, PLAN_REVISION_STATE } from './plan';
Pl217
added
ready for merge
Pl217
approved these changes
Sep 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove duplicated plan revision state codecs from plan and planTag models