Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HPC-8569: Add legacy model #132

Merged
merged 2 commits into from
Mar 20, 2024
Merged

HPC-8569: Add legacy model #132

merged 2 commits into from
Mar 20, 2024

Conversation

manelcecs
Copy link
Contributor

@manelcecs manelcecs commented Oct 30, 2023 •
edited
Loading

This PR add the model 'legacy' in order to achieve feature parity with fts-admin v1

@manelcecs manelcecs requested a review from a team as a code owner October 30, 2023 09:46
@manelcecs manelcecs added the ready for review All comments have been addressed, and the Pull Request is ready for review label Oct 30, 2023
@Pl217 Pl217 force-pushed the HPC-8569-flow-list branch from 7443efb to fa590ed Compare November 17, 2023 10:11
@Pl217 Pl217 changed the base branch from develop to tests November 17, 2023 10:11
@Pl217 Pl217 force-pushed the HPC-8569-flow-list branch from fa590ed to 8ca426e Compare November 17, 2023 11:11
Base automatically changed from tests to develop February 29, 2024 18:52
@Pl217 Pl217 force-pushed the HPC-8569-flow-list branch from 242c7c8 to 2c38410 Compare March 20, 2024 11:40
Pl217
Pl217 requested changes Mar 20, 2024
View reviewed changes
src/db/util/raw-model.ts Outdated Show resolved Hide resolved
src/db/util/raw-model.ts Outdated Show resolved Hide resolved
src/db/models/legacy.ts Outdated Show resolved Hide resolved
@Pl217 Pl217 assigned manelcecs and unassigned Pl217 Mar 20, 2024
@Pl217 Pl217 added needs major changes There are review or issue comments to address that will result in big changes and removed ready for review All comments have been addressed, and the Pull Request is ready for review labels Mar 20, 2024
@manelcecs manelcecs force-pushed the HPC-8569-flow-list branch from 2c38410 to c791c95 Compare March 20, 2024 13:46
@manelcecs manelcecs force-pushed the HPC-8569-flow-list branch from c791c95 to 9c158ee Compare March 20, 2024 13:48
@manelcecs manelcecs changed the title HPC-8569 add count method in 'raw-model' HPC-8569 add 'legacy' model for Feature Parity with fts-admin v1 Mar 20, 2024
@manelcecs manelcecs added ready for review All comments have been addressed, and the Pull Request is ready for review and removed needs major changes There are review or issue comments to address that will result in big changes labels Mar 20, 2024
@manelcecs manelcecs assigned Pl217 and unassigned manelcecs Mar 20, 2024
@Pl217 Pl217 changed the title HPC-8569 add 'legacy' model for Feature Parity with fts-admin v1 HPC-8569: Add legacy model Mar 20, 2024
@Pl217 Pl217 merged commit c119045 into develop Mar 20, 2024
2 checks passed
@Pl217 Pl217 deleted the HPC-8569-flow-list branch March 20, 2024 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pl217 Pl217 Pl217 approved these changes

Assignees

@Pl217 Pl217

Labels
ready for review All comments have been addressed, and the Pull Request is ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@manelcecs @Pl217