HPC-9280: Support for plan deletion #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only HPC and RPM admins are granted this role
Type `Models` is actually just a redefined `Database` type. So, instead of defining a local type, use the standard one. Also, all utility methods that accept argument of this type are calling it `database` and not `models`.
This code is implemented as utility method and
direct access to `models.authTarget.destroy` is
deprecated. Utility method is chosen over a
wrapper around `authTarget.destroy` because
of type mismatch that would occur because of
`actor: ParticipantId` argument, which deviates
from standard `{where, trx}` arguments.
Pl217
added
the
ready for review
enxtur
approved these changes
Nov 20, 2023
enxtur
added
ready for merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
global.DELETE_ANY_PLAN, granted to HPC and RPM adminsauthGrant.update. Executing these methods in a transaction is vital, so we need a way to specify a transaction