Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HPC-8486: Respect provided version and allow skipping validation #140

Merged
merged 4 commits into from
Mar 11, 2024

Conversation

Pl217
Copy link
Contributor

@Pl217 Pl217 commented Feb 23, 2024

No description provided.

@Pl217 Pl217 added the ready for review All comments have been addressed, and the Pull Request is ready for review label Feb 23, 2024
@Pl217 Pl217 requested a review from a team as a code owner February 23, 2024 16:15
Pl217 added 3 commits March 6, 2024 12:17
Many fetching utility methods accepted
`version` parameter, but only allowed
`'latest'` to be used. Now, allow for
`'current'` to be used as well.

To ensure versions are fetched correctly,
base entities (attachment, planEntity and
governingEntity) need to respect the version too
This will allow to significantly speed up
requests which fetch tons of data
@Delgee Delgee assigned Pl217 and unassigned Delgee Mar 11, 2024
@Delgee Delgee added ready for merge Review and testing is complete. It is ready for merging as soon as CI has finished. and removed ready for review All comments have been addressed, and the Pull Request is ready for review labels Mar 11, 2024
@Pl217 Pl217 enabled auto-merge March 11, 2024 15:44
@Pl217 Pl217 merged commit 509f4e5 into develop Mar 11, 2024
2 checks passed
@Pl217 Pl217 deleted the HPC-8486 branch March 11, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for merge Review and testing is complete. It is ready for merging as soon as CI has finished.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants