HPC-9460: Allow for read-only replica DB connection #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pl217
added
the
ready for review
Delgee
approved these changes
Jun 13, 2024
Delgee
added
ready for merge
Since Knex doesn't support read-only replicas, we need to allow for a second connection to the replica server. This assumes master and replica DB are on separate servers, but if connection to replica isn't passed, the models behave just like before. The goal is to use master DB for write operations and for transactions and replica DB should be only used for read-only operations. There are lots of changes, but it's mostly passing around of connections, just so that newly introduced replica connection can be used in `find()` method of raw model.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Knex doesn't support read-only replicas, we need to allow for a second connection to the replica server. This assumes master and replica DB are on separate servers, but if connection to replica isn't passed, the models behave just like before.
The goal is to use master DB for write operations and for transactions and replica DB should be only used for read-only operations. There are lots of changes, but it's mostly passing around of connections, just so that newly introduced replica connection can be used in
find()method of raw model.