HPC-9142: Remove entitiesAssociation model and its usages
#147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enxtur
added
the
pending prior merge
enxtur
added
the
ready for review
enxtur
changed the title
Pl217
requested changes
Apr 22, 2024
There was a problem hiding this comment.
Instead of basing this branch off develop, you should have used HPC-9142 as a base branch. The way you did it, commit c8b3b86 is duplicated. This work will need a rebase after #144 is merged. If you based this branch against HPC-9142, after merging the other PR, this one would auto-change its base to be develop.
But, regardless of that, I need to request changes here, because you didn't remove entitiesAssociation model, which I asked in this review comment.
Pl217
added
needs minor changes
enxtur
added
ready for review
Pl217
changed the title
entitiesAssociation model and its usages
Pl217
requested changes
May 10, 2024
Pl217
added
needs minor changes
Removed entitiesAssociation usage
enxtur
added
ready for review
Pl217
approved these changes
Jun 3, 2024
Pl217
removed
the
ready for review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR-144 needs to be merged first