HPC-9504: Upgrade to ESLint 9 #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Pl217
commented
Sep 5, 2024
Pl217
commented
- Start using ESLint 9 & adopt flat config
- Resolve linting errors which started appearing after the upgrade
- Update minimum version of Node.js & Yarn
With this major version of ESLint, the big change is the switch to flat config and dropping support for `.eslintignore` file
This rule would make us change `require` imports like
`import isEqual = require('lodash/isEqual')`
to
`import isEqual from 'lodash/isEqual'`
but that would require us to enable `esModuleInterop`
Typescript configuration, which we cannot do
in hpc_service, where this package is used.
Rule `@typescript-eslint/no-require-imports` was
introduced in v8 of `typescript-eslint` and replaced
old `@typescript-eslint/no-var-requires` rule
https://typescript-eslint.io/blog/announcing-typescript-eslint-v8#rule-breaking-changes
The codec was only used to cast it to type, so define a proper type instead. This is done because linting rule `@typescript-eslint/no-unused-vars` was violated
Pl217
added
ready for review
enxtur
approved these changes
Sep 6, 2024
enxtur
added
ready for merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.