Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HPC-9832: Make destroy supports softDeletionEnabled #176

Closed
wants to merge 1 commit into from
Closed

HPC-9832: Make destroy supports softDeletionEnabled #176

wants to merge 1 commit into from

Conversation

enxtur
Copy link
Contributor

@enxtur enxtur commented Oct 29, 2024

From this comment, I was initially trying to add hardDelete option to destroy method in src/db/util/sequelize-model.ts. But appears that it wasn't even support softDeletionEnabled option.

@enxtur enxtur requested a review from a team as a code owner October 29, 2024 15:01
@enxtur enxtur added the ready for review All comments have been addressed, and the Pull Request is ready for review label Oct 29, 2024
@Delgee Delgee assigned enxtur and unassigned Delgee Nov 4, 2024
@Delgee Delgee added needs major changes There are review or issue comments to address that will result in big changes and removed ready for review All comments have been addressed, and the Pull Request is ready for review labels Nov 4, 2024
@enxtur
Copy link
Contributor Author

enxtur commented Nov 4, 2024

Marking it as unnecessary

@enxtur enxtur closed this Nov 4, 2024
@enxtur enxtur deleted the HPC-9832 branch November 4, 2024 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@enxtur enxtur

Labels
needs major changes There are review or issue comments to address that will result in big changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@enxtur @Delgee