Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HPC - 8242 Stable version of FTSAdminRewrite without 'Add flow' functionality #420

Merged
merged 53 commits into from
Oct 25, 2024
Merged

HPC - 8242 Stable version of FTSAdminRewrite without 'Add flow' functionality #420

merged 53 commits into from
Oct 25, 2024

Conversation

Onitoxan
Copy link
Contributor

@Onitoxan Onitoxan commented Jan 10, 2024 •
edited
Loading

Description

FTS Admin Rewrite (FTS Admin v2) first pull request for Flow table, Pending Flow Table, Organization Table and CRUD page, Keyword page and CRUD functionalities.

Features

  • Feature Parity (Merge Organization and Merge Keywords functionalities)
  • Support for TailwindCSS
  • New custom form fields added in hpc-ui
  • 🌐 English, Spanish, French, Simplified Chinese and Arabic support
  • [New Feature] Reordering of columns on tables
  • [New Feature] Download XLSX files of current filters

And a few more, for further readability please follow to the commit history.

Next steps

  • The content of this PR doesn't include Add / Edit Flow functionality (Matyas part)
  • Test and open new tickets with parts of the application that are not properly working or is not doing good feature parity

@Onitoxan Onitoxan requested a review from a team as a code owner January 10, 2024 15:58
unocha-hpc
unocha-hpc approved these changes Jan 12, 2024
View reviewed changes
Copy link

@unocha-hpc unocha-hpc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checks have passed and this pull request is ready for manual review

Pl217
Pl217 requested changes Jan 12, 2024
View reviewed changes
Copy link
Contributor

@Pl217 Pl217 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here are some of the initial comments I have. I just reached 95332f8 and reviewed until file async-autocomplete-field.tsx. There was a problem when I ran npm install, so I found what the issue was and resolved it in a separate commit that I pushed.

package.json Outdated Show resolved Hide resolved
libs/hpc-dummy/src/lib/dummy.ts Outdated Show resolved Hide resolved
libs/hpc-data/src/lib/categories.ts Outdated Show resolved Hide resolved
libs/hpc-ui/src/lib/components/form-fields/async-autocomplete-field.tsx Outdated Show resolved Hide resolved
libs/hpc-ui/src/lib/components/form-fields/async-autocomplete-field.tsx Outdated Show resolved Hide resolved
libs/hpc-ui/src/lib/components/form-fields/async-autocomplete-field.tsx Outdated Show resolved Hide resolved
libs/hpc-ui/src/lib/components/form-fields/async-autocomplete-field.tsx Outdated Show resolved Hide resolved
libs/hpc-ui/src/lib/components/form-fields/async-autocomplete-field.tsx Outdated Show resolved Hide resolved
unocha-hpc
unocha-hpc approved these changes Jan 12, 2024
View reviewed changes
Copy link

@unocha-hpc unocha-hpc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checks have passed and this pull request is ready for manual review

unocha-hpc
unocha-hpc approved these changes Jan 12, 2024
View reviewed changes
Copy link

@unocha-hpc unocha-hpc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checks have passed and this pull request is ready for manual review

unocha-hpc
unocha-hpc approved these changes Jan 24, 2024
View reviewed changes
Copy link

@unocha-hpc unocha-hpc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checks have passed and this pull request is ready for manual review

unocha-hpc
unocha-hpc approved these changes Jan 25, 2024
View reviewed changes
Copy link

@unocha-hpc unocha-hpc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checks have passed and this pull request is ready for manual review

unocha-hpc
unocha-hpc approved these changes Jan 25, 2024
View reviewed changes
Copy link

@unocha-hpc unocha-hpc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checks have passed and this pull request is ready for manual review

unocha-hpc
unocha-hpc approved these changes Jan 26, 2024
View reviewed changes
Copy link

@unocha-hpc unocha-hpc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checks have passed and this pull request is ready for manual review

unocha-hpc
unocha-hpc approved these changes Jan 30, 2024
View reviewed changes
Copy link

@unocha-hpc unocha-hpc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checks have passed and this pull request is ready for manual review

unocha-hpc
unocha-hpc approved these changes Jan 31, 2024
View reviewed changes
Copy link

@unocha-hpc unocha-hpc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checks have passed and this pull request is ready for manual review

unocha-hpc
unocha-hpc approved these changes Mar 26, 2024
View reviewed changes
Copy link

@unocha-hpc unocha-hpc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checks have passed and this pull request is ready for manual review

@Onitoxan Onitoxan added the ready for review All comments have been addressed, and the Pull Request is ready for review label Mar 26, 2024
Pl217
Pl217 requested changes Apr 2, 2024
View reviewed changes
Copy link
Contributor

@Pl217 Pl217 left a comment •
edited by Onitoxan
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • When switching from yup to io-ts, you have left out some properties of yup codecs and removed them from io-ts. I've commented about this in few places, but not all. [X] (Commented on one of the comments the reason)
  • When removing dependencies in 5d6a12a, you haven't updated lockfile. [X]
  • Please update initial comment of this PR and write a proper PR message
  • The number of warnings about missing dependencies in useEffect hooks has increased
  • Do we need to keep both GraphQL and REST versions? [X] Removed
  • Remove usages of type casting (as keyword). I did write about this in few places inline, but not everywhere [X] (I let in some places because of necessity)

apps/hpc-ftsadmin/src/app/components/filters/filter-flows-REST-table.tsx Outdated Show resolved Hide resolved
apps/hpc-ftsadmin/src/app/components/filters/filter-flows-REST-table.tsx Outdated Show resolved Hide resolved
apps/hpc-ftsadmin/src/app/utils/form-validation.ts Outdated Show resolved Hide resolved
apps/hpc-ftsadmin/src/app/utils/form-validation.ts Outdated Show resolved Hide resolved
apps/hpc-ftsadmin/src/app/utils/form-validation.ts Outdated Show resolved Hide resolved
apps/hpc-ftsadmin/src/app/components/tables/flows-table-REST.tsx Outdated Show resolved Hide resolved
apps/hpc-ftsadmin/src/app/components/tables/flows-table.tsx Outdated Show resolved Hide resolved
apps/hpc-ftsadmin/src/app/components/tables/flows-table.tsx Outdated Show resolved Hide resolved
apps/hpc-ftsadmin/src/app/components/tables/keywords-table.tsx Show resolved Hide resolved
apps/hpc-ftsadmin/src/app/utils/table-headers.ts Outdated Show resolved Hide resolved
@Pl217 Pl217 assigned Onitoxan and unassigned Pl217 Apr 2, 2024
@Pl217 Pl217 added needs minor changes There are review or issue comments to address needs rebase and removed ready for review All comments have been addressed, and the Pull Request is ready for review labels Apr 2, 2024
unocha-hpc
unocha-hpc approved these changes Apr 3, 2024
View reviewed changes
Copy link

@unocha-hpc unocha-hpc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checks have passed and this pull request is ready for manual review

unocha-hpc
unocha-hpc approved these changes Apr 3, 2024
View reviewed changes
Copy link

@unocha-hpc unocha-hpc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checks have passed and this pull request is ready for manual review

unocha-hpc
unocha-hpc approved these changes Apr 3, 2024
View reviewed changes
Copy link

@unocha-hpc unocha-hpc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checks have passed and this pull request is ready for manual review

unocha-hpc
unocha-hpc approved these changes Apr 3, 2024
View reviewed changes
Copy link

@unocha-hpc unocha-hpc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checks have passed and this pull request is ready for manual review

unocha-hpc
unocha-hpc approved these changes Apr 3, 2024
View reviewed changes
Copy link

@unocha-hpc unocha-hpc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checks have passed and this pull request is ready for manual review

Onitoxan and others added 25 commits October 25, 2024 17:29
@Onitoxan
Remove unnecessary 'any' and dangerous type assertions
0e0009a
@Onitoxan
Remove unused values
1a3ff2e
@Onitoxan
Remove REST flow page
9c28072
@Onitoxan
Fix form-validation
62387c1
@Onitoxan
Remove TotalAmountUSD
880c5cd
@Onitoxan
Remove unnecessary components and update async-autocomplete
d769300
@Onitoxan
Remove any from draggable-list
a3181c1
@Onitoxan
Solve TODOS of keyword-table and related issues
5130d4e
@Onitoxan
Refactors, Fixes and minor updates
8f1beeb
@Onitoxan
Fix organization filter validation
b49057d
@Onitoxan
Fix CSS-in-JS formating for twin.macro
80e1240
@Onitoxan
Refactor searchFlowParams() to be shorter and more comprenhensible
d6be5d4
@Onitoxan
Fix typo and formatting issues
6497339
@Onitoxan
Remove unused functions
368a6e4
@Onitoxan
Prettify styling.tsx
525826a
@Onitoxan
Fix linting warnings
a8a485d
@Onitoxan
Disable eslint in required files
e70cfdc 
I just want this code to run on unmount and not everytime handleAbortController() re-renders
@Onitoxan
Refactor using modern ES6 features
51e0b8b
@Pl217 @Onitoxan
Format comments
1fa0709
@Onitoxan
Remove unnecessary '...otherProps'
45a8333
@Onitoxan
Replace xlxs package with exceljs
7b698b0
@Onitoxan
Abstract function to avoid repetitive code
5c6e3a9
@Onitoxan
Remove irrelevant comment
9ed6632
@Onitoxan
Rewrite handleAbortController
0c047db
@Onitoxan
Remove unused props
d7dc2f4
@Onitoxan Onitoxan enabled auto-merge October 25, 2024 15:29
unocha-hpc
unocha-hpc approved these changes Oct 25, 2024
View reviewed changes
Copy link

@unocha-hpc unocha-hpc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checks have passed and this pull request is ready for manual review

@Onitoxan Onitoxan merged commit 719cd8b into develop Oct 25, 2024
2 checks passed
@Onitoxan Onitoxan deleted the HPC-8242 branch October 25, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@unocha-hpc unocha-hpc unocha-hpc approved these changes

@Pl217 Pl217 Pl217 approved these changes

Assignees

@Pl217 Pl217

Labels
ready for review All comments have been addressed, and the Pull Request is ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Onitoxan @Pl217 @unocha-hpc @manelcecs