Use relative output path #437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit is generated by running the following command: `npx nx migrate 18.3.0` Unlike when doing major version upgrades, `nx migrate` command didn't generate `migrations.json` file this time
After upgrading Nx from 16 to 18, the output path behavior changed from absolute to relative. Although no evidence was found in the changelogs, the change in behavior is proven by experimenting.
Pl217
added
the
ready for review
unocha-hpc
approved these changes
Apr 17, 2024
Delgee
approved these changes
Apr 17, 2024
Delgee
added
ready for merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main motive of this PR is to fix the build behavior and start using relative output path. After upgrading Nx from 16 to 18, the output path behavior changed from absolute to relative. Although I couldn't find the evidence in the changelogs, the change in behavior is proven by experimenting. Building a Docker image fails without adopting to this change, because we're using a multistage build and second stage is copying the output of first (build) stage.
The update to Nx 18.3.0 was done because I thought this would allow for absolute paths again, since their changelog says:
It didn't, but I kept the update anyway, not to waste the effort. Next major version, Nx 19, should be releasing this month according to their website.