[PROPOSAL] - HPC-9658 Add cypress tests #479
Open
+3,277
−290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was no prior tests written in the monorepo, so it won't cause problems to upgrade many major versions.
Onitoxan
added
the
ready for review
unocha-hpc
approved these changes
Nov 27, 2024
Onitoxan
force-pushed
the
HPC-8546
branch
3 times, most recently
from
7597db7 to
5eef990
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nature of PR
Description
Initial implementation of tests for FTS Admin. These test consist of mocked data and mocked endpoints, so we are focusing and isolating frontend behaviors. This is a decision in order to have deterministic tests. Therefore these tests would not really be E2E tests.
How to test changes
For testing, you can run the test in headed mode by running :
All the test that are written should not fail.
TODO:
These test can be really improved and implement way more use cases, but I think as a first approach is best to review these small tests and decide if we want to invest more time into building them