Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: The dependencies for the default container must always be an array, never null. #649

Merged
merged 3 commits into from
Oct 4, 2023

Conversation

cafuego
Copy link
Contributor

@cafuego cafuego commented Oct 4, 2023

Because when it's null trying to save the settings form results in a WSOD and nobody wants that.

Refs: RWR-382

…ay, never `null`.

Because when it's `null` trying to save the settings form results in a
WSOD and nobody wants that.

Refs: RWR-382
@cafuego cafuego requested review from attiks, rupl and left23 October 4, 2023 01:52
@github-actions
Copy link

github-actions bot commented Oct 4, 2023

Build output

Composer Validate `success`

PHP Lint `success`

Docker Build `success`

Environment Setup `success`

Site Install `success`

PHP Code Sniffer `success`

Software Versions

```PHP 8.2.10 (cli) (built: Sep 2 2023 06:59:22) (NTS)
Copyright (c) The PHP Group
Zend Engine v4.2.10, Copyright (c) Zend Technologies
with Zend OPcache v8.2.10, Copyright (c), by Zend Technologies
with Xdebug v3.2.1, Copyright (c) 2002-2023, by Derick Rethans
Composer version 2.6.4 2023-09-29 10:54:46
```

Pusher: @attiks, Action: `pull_request`, Workflow: `Run tests``;

@attiks attiks self-assigned this Oct 4, 2023
Copy link
Contributor

@rupl rupl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The edit URL should be greedier but aside from that 👍🏼

config/google_tag.container.default.yml Outdated Show resolved Hide resolved
@github-actions
Copy link

github-actions bot commented Oct 4, 2023

Coverage Report

Totals Coverage
Statements: 46.3% ( 1565 / 3380 )
Methods: 26.14% ( 23 / 88 )
Lines: 46.84% ( 1542 / 3292 )

@attiks attiks merged commit 457868c into develop Oct 4, 2023
1 check passed
@lazysoundsystem lazysoundsystem deleted the cafuego/rwr-382-ga-wsod branch January 25, 2024 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants