Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Request membership for cluster #670

Draft
wants to merge 4 commits into
base: develop
Choose a base branch
from
Draft

feat: Request membership for cluster #670

wants to merge 4 commits into from

Conversation

attiks
Copy link
Contributor

@attiks attiks commented Oct 24, 2023

Refs: #RWR-329

@attiks attiks requested a review from rupl October 24, 2023 13:56
@github-actions
Copy link

github-actions bot commented Oct 24, 2023 •
edited
Loading

Build output

Composer Validate `success`

PHP Lint `success`

Docker Build `success`

Environment Setup `success`

Site Install `success`

PHP Code Sniffer `success`

Software Versions

```PHP 8.2.11 (cli) (built: Oct 6 2023 09:47:18) (NTS)
Copyright (c) The PHP Group
Zend Engine v4.2.11, Copyright (c) Zend Technologies
with Zend OPcache v8.2.11, Copyright (c), by Zend Technologies
with Xdebug v3.2.1, Copyright (c) 2002-2023, by Derick Rethans
Composer version 2.6.5 2023-10-06 10:11:52
```

Pusher: @rupl, Action: `pull_request`, Workflow: `Run tests``;

@rupl
Copy link
Contributor

rupl commented Oct 24, 2023

@attiks I can't find a button to request membership. I know you mentioned the position of the button in the ticket, but does it have to be constructed in the theme somehow? I tried a couple URLs like /COUNTRY/request or /COUNTRY/membership

@attiks
Copy link
Contributor Author

attiks commented Oct 24, 2023

Try /group/1326/request-membership

@attiks
Copy link
Contributor Author

attiks commented Oct 24, 2023

And yes, no link present yet

rupl
rupl approved these changes Oct 24, 2023
View reviewed changes
Copy link
Contributor

@rupl rupl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok yup, all working once I had the URL to request from an unprivileged user.

@rupl
Copy link
Contributor

rupl commented Oct 24, 2023

Feel free to reassign once this is merged and I'll find a home for the link.

@attiks
Copy link
Contributor Author

attiks commented Oct 24, 2023

image

@attiks attiks marked this pull request as draft October 25, 2023 07:06
rupl
rupl reviewed Oct 25, 2023
View reviewed changes
html/themes/custom/common_design_subtheme/templates/field--group--label.html.twig Outdated
<div{{ attributes.addClass(classes, 'field__item') }} style="position: relative;">
{{ item.content }}
{% if request_membership %}
<span style="position: absolute; right: 0">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you absolute maverick 🤠

Base automatically changed from RWR-381 to develop October 25, 2023 07:49
@rupl
Copy link
Contributor

rupl commented Oct 25, 2023

I approve once again. This draft may now languish in perpetuity!

@github-actions
Copy link

Coverage Report

Totals Coverage
Statements: 44.39% ( 1580 / 3559 )
Methods: 26.14% ( 23 / 88 )
Lines: 44.86% ( 1557 / 3471 )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rupl rupl rupl approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@attiks @rupl