Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Local Readme and settings.site.php.example #647

Merged
merged 5 commits into from
Sep 11, 2023
Merged

Local Readme and settings.site.php.example #647

merged 5 commits into from
Sep 11, 2023

Conversation

left23
Copy link
Contributor

@left23 left23 commented Sep 8, 2023

No description provided.

@left23 left23 self-assigned this Sep 8, 2023
@left23 left23 requested a review from orakili September 8, 2023 12:14
@left23
Copy link
Contributor Author

left23 commented Sep 8, 2023

@orakili Feel free to add to this is we missed bits.

@github-actions
Copy link

github-actions bot commented Sep 8, 2023

Build output

Composer Validate success

PHP Lint success

Docker Build success

Environment Setup success

Site Install success

PHP Code Sniffer success

Software Versions PHP 8.2.10 (cli) (built: Sep 2 2023 06:59:22) (NTS) Copyright (c) The PHP Group Zend Engine v4.2.10, Copyright (c) Zend Technologies with Zend OPcache v8.2.10, Copyright (c), by Zend Technologies with Xdebug v3.2.1, Copyright (c) 2002-2023, by Derick Rethans Composer version 2.6.2 2023-09-03 14:09:15
Drupal Logs

Pusher: @orakili, Action: pull_request, Workflow: Run tests

@orakili
Copy link
Collaborator

orakili commented Sep 11, 2023

@left23 I added an extra option to the script to stop/start the containers and another one to pull the latest PHP image and recreate the site image. The README should contain all the helpful commands. Feel free to merge if you don't see any glaring issue.

orakili
orakili previously approved these changes Sep 11, 2023
@github-actions
Copy link

Coverage Report

Totals Coverage
Statements: 11.89% ( 1092 / 9187 )
Methods: 11.86% ( 83 / 700 )
Lines: 11.89% ( 1009 / 8487 )

@left23 left23 merged commit 5d3d3dd into develop Sep 11, 2023
1 check passed
@left23 left23 deleted the local-readme branch September 11, 2023 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants