Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rw 1058 round 3 #968

Open
wants to merge 10 commits into
base: develop
Choose a base branch
from
Open

Rw 1058 round 3 #968

wants to merge 10 commits into from

Conversation

attiks
Copy link
Contributor

@attiks attiks commented Dec 11, 2024

No description provided.

@github-actions GitHub Actions
Copy link

Build output

Composer Validate success

PHP Lint success

Docker Build success

Environment Setup success

Site Install success

PHP Code Sniffer success

Software Versions Docker version 26.1.3, build b72abbb PHP 8.3.14 (cli) (built: Nov 20 2024 19:56:36) (NTS) Copyright (c) The PHP Group Zend Engine v4.3.14, Copyright (c) Zend Technologies with Zend OPcache v8.3.14, Copyright (c), by Zend Technologies with Xdebug v3.3.2, Copyright (c) 2002-2024, by Derick Rethans Composer version 2.8.4 2024-12-11 11:57:47
Drupal Logs
PHP Logs

Pusher: @attiks, Action: pull_request, Workflow: Run tests

@attiks attiks requested a review from orakili December 12, 2024 10:34
orakili
orakili reviewed Dec 13, 2024
View reviewed changes
...m/reliefweb_fields/components/reliefweb-user-posting-rights/reliefweb-user-posting-rights.js Outdated
/**
* Create a filter for users.
*/
createUserSelect: function () {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure a user name select element is the best here. That doesn't allow to filter on the email address or user ID. It can also become difficult to use when there are many entries (50+) which was the complaint the editorial team has.

That said, they can use the built-in browser text search so maybe that's enough.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The idea was to have a textbox and not a select?

orakili
orakili reviewed Dec 13, 2024
View reviewed changes
Copy link
Collaborator

@orakili orakili left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing access to the revision history (view entity history permission) for contributors.

@github-actions GitHub Actions
Copy link

Coverage Report

Totals Coverage
Statements: 18.37% ( 2307 / 12557 )
Methods: 18.95% ( 137 / 723 )
Lines: 18.34% ( 2170 / 11834 )

1 similar comment
@github-actions GitHub Actions
Copy link

Coverage Report

Totals Coverage
Statements: 18.37% ( 2307 / 12557 )
Methods: 18.95% ( 137 / 723 )
Lines: 18.34% ( 2170 / 11834 )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orakili orakili orakili left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@attiks @orakili