Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding languages and countries #1

Closed
wants to merge 9 commits into from
Closed

Adding languages and countries #1

wants to merge 9 commits into from

Conversation

TrifanBogdan24
Copy link

Respecting international abbreviations form https://www.iban.com/country-codes, I extended the enums

@TrifanBogdan24
Copy link
Author

Solved issues:

@TrifanBogdan24 TrifanBogdan24 marked this pull request as ready for review December 28, 2023 00:24
@TrifanBogdan24
Copy link
Author

for language and region detection functions for Unix systems: Improved Language Detection ardaku#55

alexandruradovici
alexandruradovici requested changes Jan 7, 2024
View reviewed changes
Copy link

@alexandruradovici alexandruradovici left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the .idea folder from the repository.

@TrifanBogdan24 TrifanBogdan24 marked this pull request as draft January 8, 2024 23:37
@TrifanBogdan24 TrifanBogdan24 marked this pull request as ready for review January 9, 2024 07:34
@TrifanBogdan24
Copy link
Author

TrifanBogdan24 commented Jan 9, 2024 •
edited
Loading

I recieved feedback from AldaronLau here : ardaku#81

I hope the .idea is no longer there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexandruradovici alexandruradovici alexandruradovici requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TrifanBogdan24 @alexandruradovici