Add poll command #193
Closed
Add poll command #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
49Indium
added
enhancement
Closed
| "\u0038\u20E3", | ||
| "\u0039\u20E3", | ||
| "\U0001F51F", | ||
| ] |
There was a problem hiding this comment.
Imo, rather than unicode these could just be the the Discord emoji names one, two, three, etc.
| max_length=100, | ||
| ) | ||
| poll_options: discord.ui.TextInput[Any] = discord.ui.TextInput( | ||
| label="The options for the poll (one per line)", |
There was a problem hiding this comment.
Might be good to include the max 10 in the dialog, as you don't find out til after you put more than 10
| poll_options: discord.ui.TextInput[Any] = discord.ui.TextInput( | ||
| label="The options for the poll (one per line)", | ||
| style=discord.TextStyle.long, | ||
| placeholder="Option 1 (e.g. UQ Computing Society)\nOption 2 (e.g. UQ Caveman Society)\nOption 3...", |
There was a problem hiding this comment.
Comment: I believe we actually refer to it as the UQ Cavepainting Society
|
Also could look better with a standard message and Discord's now built in markdown, if you don't want to go down the embed route |
|
Given that Discord is rolling out a polls feature, I'm going to close this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a poll command that allows for multi-option polls via reacts as mentioned in #165.
Originally, I was going to use buttons as @andrewj-brown suggested, but as these are displayed identically to everyone, without ephemeral madness, I could not show which choice you had selected for the poll. Better to keep it simple and use reacts, which are pretty ideal for this case (e.g. you can see who voted for what, vote total, etc.).
I did end up using a modal for creating the poll options, as this is a bit neater than entering into 11 different arguments.
I'm going to leave the ping to
/remindme, but happy to add it in if it's still wanted.