Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/emit nist goes #176

Merged
merged 16 commits into from
Dec 5, 2024
Merged

Fix/emit nist goes #176

merged 16 commits into from
Dec 5, 2024

Conversation

amarouane-ABDELHAK
Copy link
Collaborator

Fixing slash

slesaad
slesaad reviewed Dec 5, 2024
View reviewed changes
.github/workflows/deploy-goes.yml
Comment on lines +22 to +23
elif [ "${{ github.ref }}" = "refs/heads/deploy-goes-to-prod" ]; then
echo "env_name=production" >> $GITHUB_OUTPUT
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

time to remove?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why no remove? lol

slesaad
slesaad reviewed Dec 5, 2024
View reviewed changes
.github/workflows/pr-preview.yml
Comment on lines +184 to +185
echo REACT_APP_BASE_PATH="${{ vars.REACT_APP_BASE_PATH_GOES }}/${{ env.PR_STRING }}" >> ./goes-plume-viewer/.env
echo PUBLIC_URL="${{ vars.REACT_APP_BASE_PATH_GOES }}/${{ env.PR_STRING }}" >> ./goes-plume-viewer/.env
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need both of these?

@amarouane-ABDELHAK amarouane-ABDELHAK merged commit f4850ef into main Dec 5, 2024
2 checks passed
@amarouane-ABDELHAK amarouane-ABDELHAK deleted the fix/emit_nist_goes branch December 5, 2024 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slesaad slesaad slesaad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amarouane-ABDELHAK @slesaad