Deploy EMIT fixes to production #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Feature/add interactive zoom
Adding features: zoom and async markers load
slesaad
reviewed
Mar 22, 2024
slesaad
reviewed
Mar 22, 2024
| @@ -17,6 +17,8 @@ | |||
| <body> | |||
| <div id='map'></div> | |||
| <div class="marker"></div> | |||
| <div id="lds-roller-id" class="lds-roller"><div></div><div></div><div></div><div></div><div></div><div></div><div></div><div></div></div> | |||
There was a problem hiding this comment.
We need multiple divs for the spinner to work 🤷
There was a problem hiding this comment.
Because in CSS we are moving the divs
.lds-roller div {
animation: lds-roller 1.2s cubic-bezier(0.5, 0, 0.5, 1) infinite;
transform-origin: 40px 40px;
}
.lds-roller div:after {
content: " ";
display: block;
position: absolute;
width: 7px;
height: 7px;
border-radius: 50%;
background: #fff;
margin: -4px 0 0 -4px;
}
.lds-roller div:nth-child(1) {
animation-delay: -0.036s;
}
There was a problem hiding this comment.
This should probably change in the future to be consistent with VEDA "waiting spinner".
slesaad
approved these changes
Mar 22, 2024
amarouane-ABDELHAK
temporarily deployed
to
staging
GitHub Actions
Inactive
amarouane-ABDELHAK
temporarily deployed
to
staging
GitHub Actions
Inactive
amarouane-ABDELHAK
temporarily deployed
to
staging
GitHub Actions
Inactive
amarouane-ABDELHAK
temporarily deployed
to
staging
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.