Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker changes #231

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
+4 −2
Open

Docker changes #231

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e124b43
Make destination of Docker COPY an explicit directory
ar-jan Oct 18, 2024
cbec12e
Run container as unprivileged user
ar-jan Oct 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion backend/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
FROM python:3.9-bullseye

WORKDIR /usr/src/app/backend
COPY requirements.txt requirements-test.txt .
COPY requirements.txt requirements-test.txt ./
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this slash actually matter or is it just a spurious change by your autoformatter?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was intentional, to resolve a linting issue (When using COPY with more than one source file, the destination must be a directory and end with a / or a \) provided via vscode-docker.

RUN pip install -U pip pip-tools && \
pip-sync requirements.txt requirements-test.txt

Expand Down
4 changes: 3 additions & 1 deletion frontend/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,9 @@
FROM node:16

WORKDIR /usr/src/app
COPY package.json package-lock.json .
COPY package.json package-lock.json ./
RUN npm install

COPY . .

USER node
Loading