Skip to content

Commit

Permalink
Delete TODO - using 2 actions is fine
Browse files Browse the repository at this point in the history
  • Loading branch information
miker985 committed Dec 26, 2023
1 parent fa4efd3 commit e8c06dc
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions .github/workflows/pull-request.template.yml
Original file line number Diff line number Diff line change
Expand Up @@ -54,8 +54,6 @@ jobs:
pip install poetry
poetry install
# TODO: this is *backwards* - rather than update/maintain UWIT-IAM/actions/[email protected] we are re-writing it
# I do note that it appears keeping *many actions* in a single repo is an anti-pattern
- name: Auth to Google Cloud
# important! this 'auth' is referenced as `steps.auth` on the next job
id: auth
Expand All @@ -71,8 +69,6 @@ jobs:
run: |-
echo '${{ steps.auth.outputs.access_token }}' | docker login -u oauth2accesstoken --password-stdin https://us-docker.pkg.dev
# end TODO

- run: |
# this will tag the image with e.g., "pull-request-15"
# NOTE that this produces tags for ${template:app_name}.dependencies, ${template:app_name}.app, ${template:app_name}.tests (but not "${template:app_name}")
Expand Down

0 comments on commit e8c06dc

Please sign in to comment.