-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Delete TODO - using 2 actions is fine
- Loading branch information
Showing
1 changed file
with
0 additions
and
4 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -54,8 +54,6 @@ jobs: | |
pip install poetry | ||
poetry install | ||
# TODO: this is *backwards* - rather than update/maintain UWIT-IAM/actions/[email protected] we are re-writing it | ||
# I do note that it appears keeping *many actions* in a single repo is an anti-pattern | ||
- name: Auth to Google Cloud | ||
# important! this 'auth' is referenced as `steps.auth` on the next job | ||
id: auth | ||
|
@@ -71,8 +69,6 @@ jobs: | |
run: |- | ||
echo '${{ steps.auth.outputs.access_token }}' | docker login -u oauth2accesstoken --password-stdin https://us-docker.pkg.dev | ||
# end TODO | ||
|
||
- run: | | ||
# this will tag the image with e.g., "pull-request-15" | ||
# NOTE that this produces tags for ${template:app_name}.dependencies, ${template:app_name}.app, ${template:app_name}.tests (but not "${template:app_name}") | ||
|