-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cura 11482 sentry #18005
Merged
Merged
Cura 11482 sentry #18005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributes to CURA-11482
Contributes to CURA-11482
Contributes to CURA-11482
Contributes to CURA-11482
Contributes to CURA-11482
This will help us with triage of bugs for our customers. Contributes to CURA-11482
Contributes to CURA-11482
Needed for automatic Issue handling in the future Contributes to CURA-11482
wawanbreton
reviewed
Jan 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor suggestions
wawanbreton
reviewed
Jan 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One mure suggestion 😃
wawanbreton
approved these changes
Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allow logged in DF user to opt-in for Sentry crash reporting. This should help with triaging GH crashes, to quickly identify your own crash, or to help out customers in the future.
I have gone over a couple of GitHub issues to test the build, any issue which resulted in a crash and Sentry event I have labeled and linked See: https://github.com/Ultimaker/Cura/issues?q=is%3Aissue+is%3Aopen+label%3A%22Sentry+%3Aeuropean_castle%3A%22 Issues were it sliced without trouble have been closed.
Note
I also send the project base_name over as an optional (opt-in) this will allow us to write a nightly cron-job, downloading the slicing error 💥 issues and testing them nightly. If the crash is resolved in the latest build we can close the issue, if not we can get the GH issue number in Sentry and couple the information between the Sentry event and the nightly run. Discussed this with @MariMakes and I will create a Jira ticket for next sprint for this automation.
Important
When merging the different branches don't forget to change the
channels
for the conan packagesSee also the following PR's:
And the following commits:
Tip
Use the build Artifacts of this run: https://github.com/Ultimaker/Cura/actions/runs/7512777745
Which is this Sentry release: https://ultimaker-o7.sentry.io/releases/5.7.0-alpha.0%2Ba92357/?project=4506257745510401
Type of change
How Has This Been Tested?
Test Configuration:
Checklist: