Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cura 11482 sentry #18005

Merged
merged 16 commits into from
Jan 17, 2024
Merged

Cura 11482 sentry #18005

merged 16 commits into from
Jan 17, 2024

Conversation

jellespijker
Copy link
Member

@jellespijker jellespijker commented Jan 13, 2024

Description

Allow logged in DF user to opt-in for Sentry crash reporting. This should help with triaging GH crashes, to quickly identify your own crash, or to help out customers in the future.

I have gone over a couple of GitHub issues to test the build, any issue which resulted in a crash and Sentry event I have labeled and linked See: https://github.com/Ultimaker/Cura/issues?q=is%3Aissue+is%3Aopen+label%3A%22Sentry+%3Aeuropean_castle%3A%22 Issues were it sliced without trouble have been closed.

Note

I also send the project base_name over as an optional (opt-in) this will allow us to write a nightly cron-job, downloading the slicing error 💥 issues and testing them nightly. If the crash is resolved in the latest build we can close the issue, if not we can get the GH issue number in Sentry and couple the information between the Sentry event and the nightly run. Discussed this with @MariMakes and I will create a Jira ticket for next sprint for this automation.

not logged in logged in as DF user
image image

Important

When merging the different branches don't forget to change the channels for the conan packages

See also the following PR's:

And the following commits:

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Printer definition file(s)
  • Translations

How Has This Been Tested?

  • Locally
  • Test B

Test Configuration:

  • Operating System: Linux, Windows

Checklist:

Copy link
Contributor

@wawanbreton wawanbreton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor suggestions

plugins/CuraEngineBackend/CuraEngineBackend.py Outdated Show resolved Hide resolved
plugins/CuraEngineBackend/CuraEngineBackend.py Outdated Show resolved Hide resolved
resources/qml/Preferences/GeneralPage.qml Show resolved Hide resolved
resources/qml/Preferences/GeneralPage.qml Outdated Show resolved Hide resolved
Copy link
Contributor

@wawanbreton wawanbreton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One mure suggestion 😃

plugins/CuraEngineBackend/StartSliceJob.py Show resolved Hide resolved
@wawanbreton wawanbreton merged commit e48a6bb into main Jan 17, 2024
9 checks passed
@wawanbreton wawanbreton deleted the CURA-11482_sentry branch January 17, 2024 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants