-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove old AppVeyor and Travis CI files #877
Remove old AppVeyor and Travis CI files #877
Conversation
There is one more spot that could be changed perhaps (regarding Travis),
Perhaps the "does not compile on Travis CI" comments should be either removed, or be reinstated |
That line was added commented from the go in #421 and there's more discussion about specifically this in #386. Especially that last one has multiple commits and comments mentioning stuff working essentially everywhere except Travis. My bets are on Travis using something super outdated. I'm having a hard time figuring out in which particular fpc/sysutils/lazarus version that was added, but from what I read it's a compile-time error, so I've created https://github.com/UltraStar-Deluxe/USDX/tree/test-startswith to see what it does these days. BE WARNED: it seems to build just fine, but I have no idea what it's actually supposed to do or if it works. There's more commented-out things near it, and at least If possible, it'd be great if the obvious ones (search for the commented-out functions) get fixed in this PR, that way the comment about Travis can get deleted for sure. But no need to go through the codebase looking for everything else that might have a more human-readable variant these days. |
I changed the two mentioned occurrences, but
Where exactly? I didn't see any similarly commented out code in the same file. Other than that, I looked for all occurrences of I ran the game through one song quickly, which I assume is enough to check that this works (this was lyrics-font loading code) On a sidenote, there's about 30 |
I meant that if you search for
That's probably not counting the dozens of TODO I've been adding (and if not: I have dozens for my local build for things that should really be fixed in USDX. It'll happen someday). Needless to say, we're going to run into weird code, but with the comment gone, we'll tackle those as someone happens to be in that code area. I'll merge this later today. |
No description provided.