Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI/Windows: fix sourceforge download timeout #896

Merged
merged 1 commit into from
Sep 10, 2024

Conversation

DeinAlptraum
Copy link
Contributor

@DeinAlptraum DeinAlptraum commented Sep 9, 2024

Un-silence newpascal download and extraction.
Use sourceforge's automatic mirror selection.

See #894

@s09bQ5
Copy link
Collaborator

s09bQ5 commented Sep 9, 2024

Using netcologne already resulted in a redirect to the automatic mirror selection. It was the automatic mirror selection that had the SSL handshake timeout.

Can we make the powershell builtin output the progress?

@DeinAlptraum
Copy link
Contributor Author

You mean like a progress bar for the download?
I didn't see any such option in the docs

@bohning
Copy link
Collaborator

bohning commented Sep 9, 2024

You mean like a progress bar for the download? I didn't see any such option in the docs

Maybe this helps?
image

@DeinAlptraum
Copy link
Contributor Author

-ProgressAction Continue should be the default, but let's try just in case.

Edit: didn't make a difference

@basisbit
Copy link
Member

basisbit commented Sep 9, 2024

If I remember correctly, it is common practice to not use the sourceforege mirror-selector, but instead pin it to a mirror which you prefer, because otherwise you rather often get random fails.

@s09bQ5
Copy link
Collaborator

s09bQ5 commented Sep 9, 2024

But the netcologne mirror doesn't have the file we want and redirects us to the mirror selector:
https://github.com/UltraStar-Deluxe/USDX/actions/runs/10758015655/job/29832764850

@s09bQ5
Copy link
Collaborator

s09bQ5 commented Sep 10, 2024

-ProgressAction Continue should be the default, but let's try just in case.

Edit: didn't make a difference

According to https://www.youtube.com/watch?v=JwMJ35QEvSY the progress output of Invoke-WebRequest is temporarily drawn on top of previous output. I'd be surprised if this is done with escape sequences. It is probably directly manipulating the console contents, which doesn't work when the output is redirected to a logfile.

I think I prefer wget if Invoke-WebRequest is completely silent. Downloading with wget works even from downloads.sourceforge.net when raising the timeouts with -T. For the large newpascal download the progress output can be shortened to 10 lines with --progress=dot:giga.

@DeinAlptraum DeinAlptraum changed the title CI/Windows: use automatic sourceforge mirror for NSIS download CI/Windows: fix sourceforge download timeout Sep 10, 2024
Un-silence newpascal download and extraction.
Use sourceforge's automatic mirror selection.
@DeinAlptraum
Copy link
Contributor Author

Changed this back to wget with increased timeout as well as changed progress bar like you suggested.

@s09bQ5 s09bQ5 self-requested a review September 10, 2024 09:01
@barbeque-squared barbeque-squared merged commit 7895829 into UltraStar-Deluxe:master Sep 10, 2024
4 of 5 checks passed
@DeinAlptraum DeinAlptraum deleted the ci-fix branch September 10, 2024 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants