Introduce a usermode +R (block unauthed user messages) #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a client sets mode +R, unauthenticated clients will receive an error when trying to privmsg, cprivmsg, notice, cnotice, or invite them. The message will be something like: :London.UK.Eu.UnderNet.org 477 charlie alice :You need to be identified to a registered account to contact this user -- you can obtain an account from http://cservice.undernet.org/live/ This is the same numeric used when unauthed users try to join a +r channel, matching InspIRCd.
entrope
requested changes
Jul 27, 2024
| @@ -646,35 +651,37 @@ struct Client { | |||
| || HasPriv(sptr, PRIV_SEE_OPERS))) | |||
|
|
|||
| /** Clear the client's net.burst in-progress flag. */ | |||
| #define ClearBurst(x) ClrFlag(x, FLAG_BURST) | |||
| #define ClearBurst(x) ClrFlag(x, FLAG_BURST) | |||
There was a problem hiding this comment.
Could you revise this to not touch whitespace on lines that don't have text changes?
| if (is_silenced(source, dest)) | ||
| return 0; | ||
|
|
There was a problem hiding this comment.
... although I think this whitespace cleanup is fine.
| if (IsServer(source) || IsChannelService(source)) | ||
| return 0; | ||
|
|
||
| return IsBlockUnauthUsers(dest) && !IsAccount(source); |
There was a problem hiding this comment.
It's probably a little clearer and faster to write this whole function as (with line wrapping where appropriate):
return IsBlockUnauthUsers(dest) && !(IsAccount(source) || IsChannelService(source) || IsServer(source));
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a client sets mode +R, unauthenticated clients will receive an error when trying to privmsg, cprivmsg, notice, cnotice, or invite them. The message will be something like:
:London.UK.Eu.UnderNet.org 477 charlie alice :You need to be identified to a
registered account to contact this user -- you can obtain an account from
http://cservice.undernet.org/live/
This is the same numeric used when unauthed users try to join a +r channel, matching InspIRCd.