Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename jsx_brackets option to be more informative #182

Open
Glavin001 opened this issue Sep 18, 2018 · 3 comments
Open

Rename jsx_brackets option to be more informative #182

Glavin001 opened this issue Sep 18, 2018 · 3 comments

Comments

@Glavin001
Copy link
Member

Option Details
Name: JSX Brackets

See jsxBracketSameLine at https://prettier.io/docs/en/options.html#jsx-brackets

If this is to update an existing option, please describe what should be updated

The option description is:

Put the > of a multi-line JSX element at the end of the last line instead of being alone on the next line (does not apply to self closing elements).

So the same jsx_bracket is not really informative. Something like jsx_bracket_same_line.

@lassik
Copy link
Contributor

lassik commented Sep 20, 2018

Is it wise to have jsx in the option name? Other HTML/XML-based template languages could have a similar option, in which case all of those might be consolidated into a single option.

Something like "closing angle bracket on same line"? Though at least clang-format seems to say "open bracket" instead of "opening bracket"...

@Glavin001
Copy link
Member Author

Is it wise to have jsx in the option name?

💯% agree! I've been thinking the same thing lately.

The option name should be generic, and then for the time being only the JSX language would support it 👍.

I'm still not sold on what the option name should be. 🤔
/cc @szeck87 @muuvmuuv Any thoughts?

@muuvmuuv
Copy link

Thought about the same as @lassik. Something like closing_angle_sam_line would sound well explained enough

Sent with GitHawk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants